Issue 29325938: Reworked and re-added the legendary JavaScript developer job ad (Closed)
|
Created:
Sept. 4, 2015, 3:42 p.m. by Felix Dahlke Modified:
Sept. 4, 2015, 5:27 p.m. Reviewers:
Sebastian Noack Visibility:
Public. |
DescriptionReworked and re-added the legendary JavaScript developer job ad
Patch Set 1 #
Total comments: 6
Patch Set 2 : Emphasize extension development more, make "Requirements" header consistent with other job ads #
Total comments: 5
Patch Set 3 : Emphasize that applicants need to know plain JS and JS APIs #
Total comments: 2
Patch Set 4 : Actually mention browsers, s/JavaScript APIs/browser APIs/ #
Total comments: 2
MessagesTotal messages: 16
https://codereview.adblockplus.org/29325938/diff/29325939/pages/jobs/javascri... File pages/jobs/javascript-developer.md (right): https://codereview.adblockplus.org/29325938/diff/29325939/pages/jobs/javascri... pages/jobs/javascript-developer.md:7: You would work on our core adblocking code, ensuring that millions of users can block ads as effectively and efficiently as possible. You would also work on making this code work across the various browser extension APIs we support. In addition, you could contribute to any area of our code base you're interested in, or to related open source projects such as Chromium or Firefox. Still a little too much focused on the core, if you don't plan to put another job ad for an extension developer up. Also note that our style guide tells to spell it "ad blocking" with the space now. How about: You would work on our core ad blocking code, ensuring that ads are blocked as effectively and efficiently as possible. You would as well work on the Adblock Plus browser extensions for Firefox and Chromium, which use these code and are used by millions of users.
https://codereview.adblockplus.org/29325938/diff/29325939/pages/jobs/javascri... File pages/jobs/javascript-developer.md (right): https://codereview.adblockplus.org/29325938/diff/29325939/pages/jobs/javascri... pages/jobs/javascript-developer.md:13: - Strong experience with JavaScript, beyond frameworks like jQuery It seems that people don't get the "beyond frameworks like jQuery" part. How about changing it to something like: - Strong experience with JavaScript - Deep knowledge of the DOM, and preferable extension APIs I would adapt the Frontend Developer position as well.
https://codereview.adblockplus.org/29325938/diff/29325939/pages/jobs/javascri... File pages/jobs/javascript-developer.md (right): https://codereview.adblockplus.org/29325938/diff/29325939/pages/jobs/javascri... pages/jobs/javascript-developer.md:7: You would work on our core adblocking code, ensuring that millions of users can block ads as effectively and efficiently as possible. You would also work on making this code work across the various browser extension APIs we support. In addition, you could contribute to any area of our code base you're interested in, or to related open source projects such as Chromium or Firefox. On 2015/09/04 15:57:20, Sebastian Noack wrote: > Still a little too much focused on the core, if you don't plan to put another > job ad for an extension developer up. Also note that our style guide tells to > spell it "ad blocking" with the space now. How about: > > You would work on our core ad blocking code, ensuring that ads are blocked as > effectively and efficiently as possible. You would as well work on the Adblock > Plus browser extensions for Firefox and Chromium, which use these code and are > used by millions of users. > Sure, why not, reworked this a bit. https://codereview.adblockplus.org/29325938/diff/29325939/pages/jobs/javascri... pages/jobs/javascript-developer.md:13: - Strong experience with JavaScript, beyond frameworks like jQuery On 2015/09/04 16:03:43, Sebastian Noack wrote: > It seems that people don't get the "beyond frameworks like jQuery" part. How > about changing it to something like: > > - Strong experience with JavaScript > - Deep knowledge of the DOM, and preferable extension APIs > > I would adapt the Frontend Developer position as well. Not sure, I pretty much like the "beyond frameworks like jQuery" part, it communicates that we don't need someone who doesn't actually know their way around plain JS. We do have the extension API part below as a nice-to-have. Did we have applicants that do not know plain JS? Which frameworks where those using? Maybe we just need to say something like "beyond frameworks like jQuery and Angular" to make it clear?
https://codereview.adblockplus.org/29325938/diff/29325939/pages/jobs/javascri... File pages/jobs/javascript-developer.md (right): https://codereview.adblockplus.org/29325938/diff/29325939/pages/jobs/javascri... pages/jobs/javascript-developer.md:13: - Strong experience with JavaScript, beyond frameworks like jQuery On 2015/09/04 16:11:06, Felix Dahlke wrote: > On 2015/09/04 16:03:43, Sebastian Noack wrote: > > It seems that people don't get the "beyond frameworks like jQuery" part. How > > about changing it to something like: > > > > - Strong experience with JavaScript > > - Deep knowledge of the DOM, and preferable extension APIs > > > > I would adapt the Frontend Developer position as well. > > Not sure, I pretty much like the "beyond frameworks like jQuery" part, it > communicates that we don't need someone who doesn't actually know their way > around plain JS. We do have the extension API part below as a nice-to-have. > > Did we have applicants that do not know plain JS? Which frameworks where those > using? Maybe we just need to say something like "beyond frameworks like jQuery > and Angular" to make it clear? Yes, we get a lot of applications by people using jQuery, not knowing their way around the DOM unfortunately. I think it's either misleading or not explicit enough. What we try to say here is that people should know the JavaScript language well as well as the DOM API. Maybe we should do that more explicitly.
https://codereview.adblockplus.org/29325938/diff/29325945/pages/jobs/javascri... File pages/jobs/javascript-developer.md (right): https://codereview.adblockplus.org/29325938/diff/29325945/pages/jobs/javascri... pages/jobs/javascript-developer.md:7: You would work on our core ad blocking code, ensuring that ads are blocked as effectively and efficiently as possible. You would also work on the Adblock Plus browser extensions, which bring this code to millions of users. In addition, you could contribute to any area of our code base you're interested in, or to related open source projects such as Chromium or Firefox. I would explicitly mention Firefox and Chromium. To.. 1. To mention that you would do extension development on these platforms 2. It sounds weird to talks about ABP extensions, as this is only one extension for most people
https://codereview.adblockplus.org/29325938/diff/29325945/pages/jobs/javascri... File pages/jobs/javascript-developer.md (right): https://codereview.adblockplus.org/29325938/diff/29325945/pages/jobs/javascri... pages/jobs/javascript-developer.md:7: You would work on our core ad blocking code, ensuring that ads are blocked as effectively and efficiently as possible. You would also work on the Adblock Plus browser extensions, which bring this code to millions of users. In addition, you could contribute to any area of our code base you're interested in, or to related open source projects such as Chromium or Firefox. And please add Safari to the list.
https://codereview.adblockplus.org/29325938/diff/29325939/pages/jobs/javascri... File pages/jobs/javascript-developer.md (right): https://codereview.adblockplus.org/29325938/diff/29325939/pages/jobs/javascri... pages/jobs/javascript-developer.md:13: - Strong experience with JavaScript, beyond frameworks like jQuery On 2015/09/04 16:23:16, Sebastian Noack wrote: > On 2015/09/04 16:11:06, Felix Dahlke wrote: > > On 2015/09/04 16:03:43, Sebastian Noack wrote: > > > It seems that people don't get the "beyond frameworks like jQuery" part. How > > > about changing it to something like: > > > > > > - Strong experience with JavaScript > > > - Deep knowledge of the DOM, and preferable extension APIs > > > > > > I would adapt the Frontend Developer position as well. > > > > Not sure, I pretty much like the "beyond frameworks like jQuery" part, it > > communicates that we don't need someone who doesn't actually know their way > > around plain JS. We do have the extension API part below as a nice-to-have. > > > > Did we have applicants that do not know plain JS? Which frameworks where those > > using? Maybe we just need to say something like "beyond frameworks like jQuery > > and Angular" to make it clear? > > Yes, we get a lot of applications by people using jQuery, not knowing their way > around the DOM unfortunately. I think it's either misleading or not explicit > enough. What we try to say here is that people should know the JavaScript > language well as well as the DOM API. Maybe we should do that more explicitly. Alright, it's worth a shot. Didn't add browser extensions again since it's already mentioned below, and I think it's definitely a nice-to-have. Most who joined us weren't really into those before. Also added something about modern JS APIs, which I think is quite relevant. https://codereview.adblockplus.org/29325938/diff/29325945/pages/jobs/javascri... File pages/jobs/javascript-developer.md (right): https://codereview.adblockplus.org/29325938/diff/29325945/pages/jobs/javascri... pages/jobs/javascript-developer.md:7: You would work on our core ad blocking code, ensuring that ads are blocked as effectively and efficiently as possible. You would also work on the Adblock Plus browser extensions, which bring this code to millions of users. In addition, you could contribute to any area of our code base you're interested in, or to related open source projects such as Chromium or Firefox. On 2015/09/04 16:26:24, Sebastian Noack wrote: > And please add Safari to the list. Done.
https://codereview.adblockplus.org/29325938/diff/29325945/pages/jobs/javascri... File pages/jobs/javascript-developer.md (right): https://codereview.adblockplus.org/29325938/diff/29325945/pages/jobs/javascri... pages/jobs/javascript-developer.md:7: You would work on our core ad blocking code, ensuring that ads are blocked as effectively and efficiently as possible. You would also work on the Adblock Plus browser extensions, which bring this code to millions of users. In addition, you could contribute to any area of our code base you're interested in, or to related open source projects such as Chromium or Firefox. I think you didn't. :( https://codereview.adblockplus.org/29325938/diff/29325951/pages/jobs/javascri... File pages/jobs/javascript-developer.md (right): https://codereview.adblockplus.org/29325938/diff/29325951/pages/jobs/javascri... pages/jobs/javascript-developer.md:14: - Deep knowledge of the DOM and modern JavaScript APIs Well, jQuery is a JavaScript API as well, so maybe browser APIs is more accurate? Or maybe you could refer to the web platform, instead?
https://codereview.adblockplus.org/29325938/diff/29325945/pages/jobs/javascri... File pages/jobs/javascript-developer.md (right): https://codereview.adblockplus.org/29325938/diff/29325945/pages/jobs/javascri... pages/jobs/javascript-developer.md:7: You would work on our core ad blocking code, ensuring that ads are blocked as effectively and efficiently as possible. You would also work on the Adblock Plus browser extensions, which bring this code to millions of users. In addition, you could contribute to any area of our code base you're interested in, or to related open source projects such as Chromium or Firefox. On 2015/09/04 16:39:27, Sebastian Noack wrote: > I think you didn't. :( Whoops, now. https://codereview.adblockplus.org/29325938/diff/29325951/pages/jobs/javascri... File pages/jobs/javascript-developer.md (right): https://codereview.adblockplus.org/29325938/diff/29325951/pages/jobs/javascri... pages/jobs/javascript-developer.md:14: - Deep knowledge of the DOM and modern JavaScript APIs On 2015/09/04 16:39:28, Sebastian Noack wrote: > Well, jQuery is a JavaScript API as well, so maybe browser APIs is more > accurate? Or maybe you could refer to the web platform, instead? Hehe, I was pondering this and thought "browser APIs" sounds weird. But I can see how "JavaScript APIs" can easily be misunderstood. I guess this is the most precise way to put it, let's hope people read.
LGTM. Mind adapting the frontend developer position regarding the "beyond jQuery part" in a separate commit?
https://codereview.adblockplus.org/29325938/diff/29325954/pages/jobs/javascri... File pages/jobs/javascript-developer.md (right): https://codereview.adblockplus.org/29325938/diff/29325954/pages/jobs/javascri... pages/jobs/javascript-developer.md:17: - Good communication skills in English Nit: For consistence wit the other developer postions this should be "Excellent communication skills in English", or we should change the other job ads as well.
https://codereview.adblockplus.org/29325938/diff/29325954/pages/jobs/javascri... File pages/jobs/javascript-developer.md (right): https://codereview.adblockplus.org/29325938/diff/29325954/pages/jobs/javascri... pages/jobs/javascript-developer.md:17: - Good communication skills in English On 2015/09/04 17:01:51, Sebastian Noack wrote: > Nit: For consistence wit the other developer postions this should be "Excellent > communication skills in English", or we should change the other job ads as well. For reference, as agreed in the review of the Python position, we go with good. So still LGTM.
Message was sent while issue was closed.
Pushed: https://hg.adblockplus.org/web.eyeo.com/rev/c79d57ce822f 
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
