Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: modules/web/manifests/server.pp

Issue 29438571: Noissue - Improve web repository clone command (Closed)
Patch Set: Created May 16, 2017, 1:01 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: modules/web/manifests/server.pp
===================================================================
--- a/modules/web/manifests/server.pp
+++ b/modules/web/manifests/server.pp
@@ -107,8 +107,13 @@
creates => "/opt/cms/.hg/hgrc",
}
+ $fetch_repo_cmd = [
+ "hg", "clone", "-U", "https://hg.adblockplus.org/${repository}",
mathias 2017/05/16 09:02:07 Please use single quotes.
+ "/home/www/${repository}",
+ ]
+
exec {"fetch_repo":
- command => "hg clone -U https://hg.adblockplus.org/${repository} /home/www/${repository}",
+ command => shellquote($fetch_repo_cmd),
path => ["/usr/bin/", "/bin/"],
require => Package['mercurial'],
user => www,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld