Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29464559: #1538 - Remove class statsmaster and associated resources (Closed)

Created:
June 13, 2017, 9:43 a.m. by mathias
Modified:
June 13, 2017, 10:34 a.m.
Reviewers:
f.lopez
CC:
Fred, f.nicolaisen
Visibility:
Public.

Description

#1538 - Remove class statsmaster and associated resources

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2303 lines) Patch
D hiera/roles/statsmaster.yaml View 1 chunk +0 lines, -7 lines 0 comments Download
D modules/adblockplus/manifests/host/statsmaster.pp View 1 chunk +0 lines, -54 lines 0 comments Download
M modules/private-stub/hiera/hosts.yaml View 1 chunk +0 lines, -6 lines 2 comments Download
D modules/statsmaster/files/site.conf View 1 chunk +0 lines, -52 lines 0 comments Download
D modules/statsmaster/files/usercounts.html View 1 chunk +0 lines, -278 lines 0 comments Download
D modules/statsmaster/manifests/awstats.pp View 1 chunk +0 lines, -169 lines 0 comments Download
D modules/statsmaster/manifests/downloads.pp View 1 chunk +0 lines, -36 lines 0 comments Download
D modules/statsmaster/manifests/init.pp View 1 chunk +0 lines, -76 lines 0 comments Download
D modules/statsmaster/templates/anonymize_ips_head.erb View 1 chunk +0 lines, -12 lines 0 comments Download
D modules/statsmaster/templates/anonymize_ips_item.erb View 1 chunk +0 lines, -27 lines 0 comments Download
D modules/statsmaster/templates/awstats.conf View 1 chunk +0 lines, -1480 lines 0 comments Download
D modules/statsmaster/templates/build_static_head.erb View 1 chunk +0 lines, -49 lines 0 comments Download
D modules/statsmaster/templates/build_static_item.erb View 1 chunk +0 lines, -4 lines 0 comments Download
D modules/statsmaster/templates/index_foot.html.erb View 1 chunk +0 lines, -3 lines 0 comments Download
D modules/statsmaster/templates/index_head.html.erb View 1 chunk +0 lines, -8 lines 0 comments Download
D modules/statsmaster/templates/index_item.html.erb View 1 chunk +0 lines, -7 lines 0 comments Download
D modules/statsmaster/templates/process_logs_head.erb View 1 chunk +0 lines, -17 lines 0 comments Download
D modules/statsmaster/templates/process_logs_item.erb View 1 chunk +0 lines, -2 lines 0 comments Download
D modules/statsmaster/templates/sitescripts.ini.erb View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 4
mathias
June 13, 2017, 9:43 a.m. (2017-06-13 09:43:49 UTC) #1
f.lopez
https://codereview.adblockplus.org/29464559/diff/29464560/modules/private-stub/hiera/hosts.yaml File modules/private-stub/hiera/hosts.yaml (left): https://codereview.adblockplus.org/29464559/diff/29464560/modules/private-stub/hiera/hosts.yaml#oldcode70 modules/private-stub/hiera/hosts.yaml:70: stats1: Shouldn't this be absent?
June 13, 2017, 9:47 a.m. (2017-06-13 09:47:35 UTC) #2
mathias
https://codereview.adblockplus.org/29464559/diff/29464560/modules/private-stub/hiera/hosts.yaml File modules/private-stub/hiera/hosts.yaml (left): https://codereview.adblockplus.org/29464559/diff/29464560/modules/private-stub/hiera/hosts.yaml#oldcode70 modules/private-stub/hiera/hosts.yaml:70: stats1: On 2017/06/13 09:47:35, f.lopez wrote: > Shouldn't this ...
June 13, 2017, 10:15 a.m. (2017-06-13 10:15:23 UTC) #3
f.lopez
June 13, 2017, 10:15 a.m. (2017-06-13 10:15:53 UTC) #4 
On 2017/06/13 10:15:23, mathias wrote:
>
https://codereview.adblockplus.org/29464559/diff/29464560/modules/private-stu...
> File modules/private-stub/hiera/hosts.yaml (left):
> 
>
https://codereview.adblockplus.org/29464559/diff/29464560/modules/private-stu...
> modules/private-stub/hiera/hosts.yaml:70: stats1:
> On 2017/06/13 09:47:35, f.lopez wrote:
> > Shouldn't this be absent? 
> 
> Nah, not in development. But in the production version, yes.

ok fair enough, LGTM then!

Powered by Google App Engine
This is Rietveld