Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: modules/adblockplus/manifests/log.pp

Issue 29483575: #2007 - Create abp::legacy::webserver class for hiera compatibility (Closed)
Patch Set: Creates a full commit for refactoring webserver manifest Created July 10, 2017, 6:29 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: modules/adblockplus/manifests/log.pp
===================================================================
--- a/modules/adblockplus/manifests/log.pp
+++ b/modules/adblockplus/manifests/log.pp
@@ -13,7 +13,7 @@
#
# [*rotations*]
# A hash of adblockplus::log::rotation $name => $parameter items
-# to set up in this context, i.e. via Hiera.
+# to set up in this context via Hiera only.
#
# [*trackers*]
# A hash of adblockplus::log::rotation $title => $parameter items
@@ -32,7 +32,6 @@
#
class adblockplus::log (
$ensure = 'present',
- $rotations = hiera('adblockplus::log::rotations', {}),
$trackers = hiera('adblockplus::log::trackers', {}),
) {
@@ -92,6 +91,7 @@
}
# See modules/adblockplus/manifests/log/rotation.pp
+ $rotations = hiera_hash('adblockplus::log::rotations', {})
mathias 2017/07/12 16:13:46 Looks like an unrelated change to me, something th
f.lopez 2017/07/12 16:25:59 Agggh your are right, my mistake
create_resources('adblockplus::log::rotation', $rotations)
# See modules/adblockplus/manifests/log/tracker.pp

Powered by Google App Engine
This is Rietveld