Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29551632: Issue 5735 - Use JS Map instead of Object for global filtersByDomain in elemHide.js (Closed)

Created:
Sept. 21, 2017, 11:42 a.m. by sergei
Modified:
Sept. 26, 2017, 1:58 p.m.
Reviewers:
wspee, kzar, hub, Wladimir Palant
CC:
Felix Dahlke
Base URL:
https://github.com/adblockplus/adblockpluscore.git
Visibility:
Public.

Description

# depends on https://codereview.adblockplus.org/29550662/

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M lib/elemHide.js View 5 chunks +7 lines, -7 lines 1 comment Download

Messages

Total messages: 2
sergei
https://codereview.adblockplus.org/29551632/diff/29551633/lib/elemHide.js File lib/elemHide.js (right): https://codereview.adblockplus.org/29551632/diff/29551633/lib/elemHide.js#newcode110 lib/elemHide.js:110: filtersByDomain.set(domain, filters = Object.create(null)); filters are changed in https://codereview.adblockplus.org/29551635/
Sept. 21, 2017, noon (2017-09-21 12:00:26 UTC) #1
Wladimir Palant
Sept. 25, 2017, 11:09 a.m. (2017-09-25 11:09:05 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld