Issue 6064 - Put C++ code into a configurable namespace

compiled/bindings/generator.cpp

Index: compiled/bindings/generator.cpp
diff --git a/compiled/bindings/generator.cpp b/compiled/bindings/generator.cpp
index 528cffb36ccfd91ea1db1714523d0ae89e5dd738..b6189975617410d9c5e4848e79104cb755aa2c7e 100644
--- a/compiled/bindings/generator.cpp
+++ b/compiled/bindings/generator.cpp
@@ -20,11 +20,13 @@
 #include "generator.h"
 #include "library.h"
 
+ABP_NS_USING
+
 namespace
 {
   std::vector<bindings_internal::ClassInfo> classes;
 }
-
+ABP_NS_BEGIN

[hub, 2017/11/21 16:48:39]

the anonymous namespace above should be within this namespace.

[sergei, 2017/11/22 09:39:26]

Here this anonymous namespace can be in ABP_NS namespace but in general I am not
sure that we should make it so strict because in this case one will have to use
`ABP_NS::` prefix sometimes in order to get access to things declared in the
ABP_NS::<unnamed_namespace> what can be rather annoying and even confusing
because there is already ABP_NS_USING. Do you mind to generally not put
anonymous namespaces already residing in our translation unit into ABP_NS if
there is no conflict?

 namespace bindings_internal
 {
   FunctionInfo::FunctionInfo()
@@ -477,7 +479,7 @@ namespace bindings_internal
         printf("  %i: exports.%s,\n", item.first, item.second.c_str());
       puts("};");
   }
-}
+} // namespace bindings_internal
 
 void printBindings()
 {
@@ -488,3 +490,5 @@ void printBindings()
   for (const auto& cls : classes)
     bindings_internal::printClassMapping(cls);
 }
+
+ABP_NS_END