Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5713977044631552: Redirect incorrect Android devbuild update URL (Closed)

Created:
Dec. 17, 2013, 2:43 p.m. by Felix Dahlke
Modified:
March 4, 2014, 12:03 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

In ABP for Android 1.2, we've accidentally put all release users on the devbuild update channel. However, luckily, the URL is incorrect (it's the default one from libadblockplus), so we can safely redirect this to the real release channel - the real devbuild users are still on the real devbuild channel.

Patch Set 1 #

Patch Set 2 : Redirect the old devbuild update URL, not the new one #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M modules/downloadserver/files/downloads.adblockplus.org View 1 1 chunk +11 lines, -0 lines 1 comment Download

Messages

Total messages: 9
Felix Dahlke
Dec. 17, 2013, 2:44 p.m. (2013-12-17 14:44:57 UTC) #1
Wladimir Palant
This is actually the correct new update URL for the development builds. Rather than redirect ...
Dec. 17, 2013, 3:48 p.m. (2013-12-17 15:48:14 UTC) #2
Felix Dahlke
On 2013/12/17 15:48:14, Wladimir Palant wrote: > This is actually the correct new update URL ...
Dec. 17, 2013, 3:55 p.m. (2013-12-17 15:55:05 UTC) #3
Wladimir Palant
The format isn't the same, we will need to provide both URLs for a while. ...
Dec. 17, 2013, 3:57 p.m. (2013-12-17 15:57:48 UTC) #4
Felix Dahlke
On 2013/12/17 15:57:48, Wladimir Palant wrote: > The format isn't the same, we will need ...
Dec. 18, 2013, 12:41 a.m. (2013-12-18 00:41:35 UTC) #5
Felix Dahlke
I didn't understand the actual problem when creating this issue. The new devbuild update URL ...
Feb. 27, 2014, 6:07 p.m. (2014-02-27 18:07:28 UTC) #6
Wladimir Palant
http://codereview.adblockplus.org/5713977044631552/diff/5639274879778816/modules/downloadserver/files/downloads.adblockplus.org File modules/downloadserver/files/downloads.adblockplus.org (right): http://codereview.adblockplus.org/5713977044631552/diff/5639274879778816/modules/downloadserver/files/downloads.adblockplus.org#newcode36 modules/downloadserver/files/downloads.adblockplus.org:36: rewrite ^ https://adblockplus.org/androidupdates.xml?$query_string redirect; Won't the two update mechanisms ...
March 3, 2014, 7:44 a.m. (2014-03-03 07:44:18 UTC) #7
Felix Dahlke
On 2014/03/03 07:44:18, Wladimir Palant wrote: > http://codereview.adblockplus.org/5713977044631552/diff/5639274879778816/modules/downloadserver/files/downloads.adblockplus.org > File http://modules/downloadserver/files/downloads.adblockplus.org (right): > > http://codereview.adblockplus.org/5713977044631552/diff/5639274879778816/modules/downloadserver/files/downloads.adblockplus.org#newcode36 ...
March 3, 2014, 9:18 a.m. (2014-03-03 09:18:19 UTC) #8
Wladimir Palant
March 3, 2014, 3:11 p.m. (2014-03-03 15:11:21 UTC) #9
If you are right and the new update mechanism isn't hooked up at all (looks like
it): LGTM

Powered by Google App Engine
This is Rietveld