Issue 10171027: Compile subscriptions.xml into the libadblockplus build and make itusable

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10171027: Compile subscriptions.xml into the libadblockplus build and make itusable (Closed)

Created:
April 19, 2013, 7:59 a.m. by Wladimir Palant

Modified:
April 30, 2013, 9:35 a.m.

Reviewers:
Felix Dahlke, Oleksandr

Visibility:
Public.

Description

Compile subscriptions.xml into the libadblockplus build and make it usable

Patch Set 1 #

Total comments: 3

Created: April 19, 2013, 7:59 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -16 lines)			Patch
M	convert_js.py	View	2 chunks	+31 lines, -6 lines	1 comment	Download
M	include/AdblockPlus/FilterEngine.h	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	lib/api.js	View	1 chunk	+19 lines, -0 lines	0 comments	Download
M	libadblockplus.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	shell/src/SubscriptionsCommand.cpp	View	2 chunks	+9 lines, -2 lines	0 comments	Download
M	src/FilterEngine.cpp	View	1 chunk	+9 lines, -4 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Oleksandr

On 2013/04/19 08:00:11, Wladimir Palant wrote: LGTM

April 30, 2013, 8:39 a.m. (2013-04-30 08:39:01 UTC) #2

Felix Dahlke

LGTM with the indentation fixed http://codereview.adblockplus.org/10171027/diff/1/convert_js.py File convert_js.py (right): http://codereview.adblockplus.org/10171027/diff/1/convert_js.py#newcode26 convert_js.py:26: fileHandle = codecs.open(file, 'rb', ...

April 30, 2013, 8:59 a.m. (2013-04-30 08:59:17 UTC) #3

Wladimir Palant

April 30, 2013, 9:35 a.m. (2013-04-30 09:35:49 UTC) #4

I fixed indentation in
https://hg.adblockplus.org/libadblockplus/rev/89b9c6e3d6aa

http://codereview.adblockplus.org/10171027/diff/1/src/FilterEngine.cpp
File src/FilterEngine.cpp (right):

http://codereview.adblockplus.org/10171027/diff/1/src/FilterEngine.cpp#newcod...
src/FilterEngine.cpp:362: #if FILTER_ENGINE_STUBS
On 2013/04/30 08:59:17, Felix H. Dahlke wrote:
> What's with this diff? FILTER_ENGINE_STUBS has been gone for a while.

This diff is rather old as well, check the issue date.

Expand All Messages | Collapse All Messages