Issue 10178013: update for MSVS libadblockplus project

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10178013: update for MSVS libadblockplus project (Closed)

Created:
April 12, 2013, 2:02 p.m. by Eric

Modified:
April 12, 2013, 3:05 p.m.

Reviewers:
Felix Dahlke, Oleksandr

Visibility:
Public.

Description

update for MSVS libadblockplus project

Patch Set 1 #

Created: April 12, 2013, 2:02 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -3 lines)			Patch
	M	MSVS/libadblockplus.vcxproj	View		5 chunks	+22 lines, -3 lines	0 comments	Download
	M	MSVS/libadblockplus.vcxproj.filters	View		1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

Felix Dahlke

Is this just a regeneration of the project files using gyp or are these manual ...

April 12, 2013, 2:20 p.m. (2013-04-12 14:20:45 UTC) #2

Oleksandr

On 2013/04/12 14:20:45, Felix H. Dahlke wrote: > Is this just a regeneration of the ...

April 12, 2013, 2:23 p.m. (2013-04-12 14:23:25 UTC) #3

Felix Dahlke

I don't think it's wise to diverge from the project files generated via GYP, we're ...

April 12, 2013, 2:25 p.m. (2013-04-12 14:25:16 UTC) #4

Oleksandr

On 2013/04/12 14:25:16, Felix H. Dahlke wrote: > I don't think it's wise to diverge ...

April 12, 2013, 2:28 p.m. (2013-04-12 14:28:12 UTC) #5

Eric

On 2013/04/12 14:25:16, Felix H. Dahlke wrote: > I don't think it's wise to diverge ...

April 12, 2013, 2:31 p.m. (2013-04-12 14:31:39 UTC) #6

Felix Dahlke

April 12, 2013, 2:39 p.m. (2013-04-12 14:39:56 UTC) #7

On 2013/04/12 14:31:39, Eric wrote:
> On 2013/04/12 14:25:16, Felix H. Dahlke wrote:
> > I don't think it's wise to diverge from the project files generated via GYP
> 
> The first problem I had was with a gyp-generated project. It was invoking
> setup_env.bat, which we didn't have, etc. Oleksandr steered me right (and
fixed
> the README).

Yes, it's not a Yak I want to shave right now either. But I believe we have to
do it at some point.

Expand All Messages | Collapse All Messages