Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 10259051: Fixed: Compiler error due to string length limit in Visual C++ (Closed)

Created:
April 27, 2013, 11:33 p.m. by Wladimir Palant
Modified:
April 30, 2013, 8:58 a.m.
Reviewers:
Felix Dahlke, Oleksandr
Visibility:
Public.

Description

With this change we initialize our buffer as a char array rather than a string literal, an array doesn't seem to have any length limits. Also, we create std::string instances explicitly and specify the string length while at it - this makes sure the strings don't need to be scanned for the null character.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -28 lines) Patch
M convert_js.py View 1 chunk +34 lines, -26 lines 1 comment Download
M src/FilterEngine.cpp View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
April 27, 2013, 11:33 p.m. (2013-04-27 23:33:14 UTC) #1
Felix Dahlke
LGTM with a nit http://codereview.adblockplus.org/10259051/diff/1/convert_js.py File convert_js.py (right): http://codereview.adblockplus.org/10259051/diff/1/convert_js.py#newcode22 convert_js.py:22: print >>outHandle, 'namespace {' Nit ...
April 29, 2013, 9:53 a.m. (2013-04-29 09:53:41 UTC) #2
Oleksandr
April 30, 2013, 8:58 a.m. (2013-04-30 08:58:28 UTC) #3
On 2013/04/29 09:53:41, Felix H. Dahlke wrote:
> LGTM with a nit
> 
> http://codereview.adblockplus.org/10259051/diff/1/convert_js.py
> File convert_js.py (right):
> 
> http://codereview.adblockplus.org/10259051/diff/1/convert_js.py#newcode22
> convert_js.py:22: print >>outHandle, 'namespace {'
> Nit pick: Newline before {

LGTM

Powered by Google App Engine
This is Rietveld