Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 10290027: Rewrite js2c.py to avoid positional non-file arguments (Closed)

Created:
April 24, 2013, 5:52 p.m. by Eric
Modified:
April 25, 2013, 3:16 p.m.
Visibility:
Public.

Description

Rewrite js2c.py to avoid positional non-file arguments. Tested on Windows. Patch set 1 is from the v8 subrepository. Patch set 2 from libadblockplus

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M createsolution.bat View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Eric
April 24, 2013, 6:10 p.m. (2013-04-24 18:10:04 UTC) #1
Wladimir Palant
We shouldn't do that in our repository - we should rather file a V8 bug ...
April 25, 2013, 6:53 a.m. (2013-04-25 06:53:28 UTC) #2
Eric
April 25, 2013, 1:54 p.m. (2013-04-25 13:54:34 UTC) #3
On 2013/04/25 06:53:28, Wladimir Palant wrote:
> We shouldn't do that in our repository - we should rather file a V8 bug (or
> attach the patch to an existing bug) to make Google fix it.

OK. I'll do that.

Powered by Google App Engine
This is Rietveld