Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 10421060: Make sure to work properly with Unicode paths on Windows (Closed)

Created:
May 14, 2013, 1:38 p.m. by Wladimir Palant
Modified:
May 22, 2013, 2:40 p.m.
Reviewers:
Felix Dahlke, Oleksandr
Visibility:
Public.

Description

Make sure to work properly with Unicode paths on Windows

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M src/DefaultFileSystem.cpp View 2 chunks +21 lines, -7 lines 1 comment Download
M test/DefaultFileSystem.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Wladimir Palant
May 14, 2013, 1:38 p.m. (2013-05-14 13:38:10 UTC) #1
Felix Dahlke
LGTM with one nit http://codereview.adblockplus.org/10421060/diff/1/src/DefaultFileSystem.cpp File src/DefaultFileSystem.cpp (right): http://codereview.adblockplus.org/10421060/diff/1/src/DefaultFileSystem.cpp#newcode62 src/DefaultFileSystem.cpp:62: #define NormalizePath(path) (path) Would rather ...
May 17, 2013, 9:38 a.m. (2013-05-17 09:38:14 UTC) #2
Wladimir Palant
Addressed the nit with https://hg.adblockplus.org/libadblockplus/rev/0c15bb521839.
May 17, 2013, 10:51 a.m. (2013-05-17 10:51:54 UTC) #3
Oleksandr
May 20, 2013, 7:33 a.m. (2013-05-20 07:33:03 UTC) #4
On 2013/05/17 10:51:54, Wladimir Palant wrote:
> Addressed the nit with
> https://hg.adblockplus.org/libadblockplus/rev/0c15bb521839.

LGTM

Powered by Google App Engine
This is Rietveld