Don`t use stat() on Windows, use a Unicode-safe Windows function instead

IMHO, file access specifics on Windows are complicated enough that stat() is unusable. I replaced stat() with GetFileAttributesExW(), this is both Unicode-safe and will give us high-precision file modification times.

[Felix Dahlke, 2013-05-17 09:18:49]

http://codereview.adblockplus.org/10518027/diff/1/include/AdblockPlus/FileSys...
File include/AdblockPlus/FileSystem.h (right):

http://codereview.adblockplus.org/10518027/diff/1/include/AdblockPlus/FileSys...
include/AdblockPlus/FileSystem.h:34: inline StatResult()
The inline keyword is only necessary for free functions, you can remove it here.

http://codereview.adblockplus.org/10518027/diff/1/include/AdblockPlus/FileSys...
include/AdblockPlus/FileSystem.h:39: lastModified = false;
I think it'd be cleaner to set this to 0, being an int.

http://codereview.adblockplus.org/10518027/diff/1/src/DefaultFileSystem.cpp
File src/DefaultFileSystem.cpp (right):

http://codereview.adblockplus.org/10518027/diff/1/src/DefaultFileSystem.cpp#n...
src/DefaultFileSystem.cpp:86: if (err == ERROR_FILE_NOT_FOUND ||
ERROR_PATH_NOT_FOUND || ERROR_INVALID_DRIVE)
Shouldn't this be "err == ERROR_FILE_NOT_FOUND || err == ERROR_PATH_NOT_FOUND
..."?

[Oleksandr, 2013-05-20 09:48:15]

On 2013/05/17 10:44:14, Wladimir Palant wrote:

LGTM

[Felix Dahlke, 2013-05-22 06:16:21]

LGTM