Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 10807006: Use a binary 0 as string separator (Closed)

Created:
May 24, 2013, 3:22 p.m. by Felix Dahlke
Modified:
Nov. 12, 2013, 10:11 a.m.
Visibility:
Public.

Description

This makes things not break horribly when we marshall strings containing ";". However, I left the TODO, as we'll eventually want something more robust.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/shared/Communication.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6
Felix Dahlke
May 24, 2013, 3:22 p.m. (2013-05-24 15:22:39 UTC) #1
Wladimir Palant
I don't really like the approach (and zero-terminated strings in general). Strings need to be ...
May 27, 2013, 9:43 a.m. (2013-05-27 09:43:13 UTC) #2
Oleksandr
On 2013/05/27 09:43:13, Wladimir Palant wrote: > I don't really like the approach (and zero-terminated ...
May 27, 2013, 2:54 p.m. (2013-05-27 14:54:50 UTC) #3
Wladimir Palant
On 2013/05/27 14:54:50, Oleksandr wrote: > I think if we go that way it would ...
May 27, 2013, 3:22 p.m. (2013-05-27 15:22:43 UTC) #4
Oleksandr
On 2013/05/27 15:22:43, Wladimir Palant wrote: > On 2013/05/27 14:54:50, Oleksandr wrote: > > I ...
May 27, 2013, 4:28 p.m. (2013-05-27 16:28:17 UTC) #5
Felix Dahlke
June 3, 2013, 10:19 a.m. (2013-06-03 10:19:10 UTC) #6
On 2013/05/27 09:43:13, Wladimir Palant wrote:
> I don't really like the approach (and zero-terminated strings in general).
> Strings need to be serialized by writing out their length as (16 bit?)
integer,
> followed by the string data.

Agreed, it was just a hack. Closing this since we have a proper implementation
now: http://codereview.adblockplus.org/10824027/

Powered by Google App Engine
This is Rietveld