Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 10973008: Make tabs hang less (Closed)

Created:
June 13, 2013, 9:03 a.m. by Felix Dahlke
Modified:
Nov. 12, 2013, 10:12 a.m.
Visibility:
Public.

Description

With these changes, tabs aren't hanging as much as they used to, but still occasionally. This includes: - Open up the pipe as soon as possible in the engine - Increase WaitNamedPipe timeout, decrease spawn engine timeout - Sleep before the first attempt to open the pipe of the newly spawned engine - Reduce check interval while waiting for the newly spawned engine

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M src/engine/main.cpp View 2 chunks +10 lines, -8 lines 0 comments Download
M src/plugin/AdblockPlusClient.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/shared/Communication.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Felix Dahlke
June 13, 2013, 9:05 a.m. (2013-06-13 09:05:06 UTC) #1
Wladimir Palant
LGTM
June 13, 2013, 9:15 a.m. (2013-06-13 09:15:04 UTC) #2
Oleksandr
June 13, 2013, 9:46 a.m. (2013-06-13 09:46:52 UTC) #3
On 2013/06/13 09:15:04, Wladimir Palant wrote:
> LGTM

LGTM

Powered by Google App Engine
This is Rietveld