Issue 11037099: First run detection fix

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11037099: First run detection fix (Closed)

Created:
July 11, 2013, 10:03 a.m. by Oleksandr

Modified:
July 20, 2013, 10:39 p.m.

Reviewers:
Wladimir Palant

Visibility:
Public.

Patch Set 2 : Cleaner version #

Created: July 20, 2013, 8:33 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	lib/init.js	View		2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Wladimir Palant

Only the change to lib/init.js should be necessary - everything else seems to be debug ...

July 11, 2013, 11:36 a.m. (2013-07-11 11:36:21 UTC) #2

Oleksandr

http://codereview.adblockplus.org/11037099/diff/1/src/FilterEngine.cpp File src/FilterEngine.cpp (right): http://codereview.adblockplus.org/11037099/diff/1/src/FilterEngine.cpp#newcode167 src/FilterEngine.cpp:167: return temp; On 2013/07/11 11:36:21, Wladimir Palant wrote: > ...

July 11, 2013, 12:18 p.m. (2013-07-11 12:18:45 UTC) #3

Wladimir Palant

July 11, 2013, 12:56 p.m. (2013-07-11 12:56:20 UTC) #4

http://codereview.adblockplus.org/11037099/diff/1/src/FilterEngine.cpp
File src/FilterEngine.cpp (right):

http://codereview.adblockplus.org/11037099/diff/1/src/FilterEngine.cpp#newcod...
src/FilterEngine.cpp:167: return temp;
I see. I actually suggested in the other review that this logic should be
implemented in the adblockplusie engine - calling IsFirstRun() in the engine
shouldn't cause unexpected side-effects. And it isn't given that all
applications only want to query IsFirstRun() once.

Expand All Messages | Collapse All Messages