Issue 11339006: GetAppLocale and GetDocumentationLink for IE faking

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11339006: GetAppLocale and GetDocumentationLink for IE faking (Closed)

Created:
Aug. 1, 2013, 7:36 a.m. by Oleksandr

Modified:
Aug. 1, 2013, 10:31 p.m.

Reviewers:
Felix Dahlke, Wladimir Palant

Visibility:
Public.

Description

GetAppLocale and GetDocumentationLink for IE faking

Patch Set 1 #

Total comments: 2

Created: Aug. 1, 2013, 7:36 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	include/AdblockPlus/FilterEngine.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	src/FilterEngine.cpp	View		1 chunk	+12 lines, -0 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Wladimir Palant

http://codereview.adblockplus.org/11339006/diff/1/src/FilterEngine.cpp File src/FilterEngine.cpp (right): http://codereview.adblockplus.org/11339006/diff/1/src/FilterEngine.cpp#newcode284 src/FilterEngine.cpp:284: return locale->AsString(); The app locale is being passed in ...

Aug. 1, 2013, 11:49 a.m. (2013-08-01 11:49:09 UTC) #2

This is not needed then, so I'm closing the issue

Expand All Messages | Collapse All Messages