Issue 11369200: Disable everywhere fix

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11369200: Disable everywhere fix (Closed)

Created:
Aug. 13, 2013, 2:18 p.m. by Oleksandr

Modified:
Aug. 21, 2013, 7:07 a.m.

Reviewers:
Felix Dahlke, Wladimir Palant

Visibility:
Public.

Patch Set 2 : TogglePluginEnabled transfered to engine #

Created: Aug. 20, 2013, 7:34 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -13 lines)			Patch
M	src/engine/Main.cpp	View	1	1 chunk	+6 lines, -1 line	0 comments	Download
M	src/plugin/AdblockPlusClient.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/plugin/AdblockPlusClient.cpp	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/plugin/PluginSettings.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/plugin/PluginSettings.cpp	View	1	1 chunk	+1 line, -9 lines	0 comments	Download
M	src/shared/Communication.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Wladimir Palant

http://codereview.adblockplus.org/11369200/diff/1/src/plugin/PluginSettings.cpp File src/plugin/PluginSettings.cpp (right): http://codereview.adblockplus.org/11369200/diff/1/src/plugin/PluginSettings.cpp#newcode190 src/plugin/PluginSettings.cpp:190: GetPluginEnabled() ? SetPluginDisabled() : SetPluginEnabled(); The SetPluginEnabled/SetPluginDisabled functions are ...

Aug. 13, 2013, 2:25 p.m. (2013-08-13 14:25:29 UTC) #3

Wladimir Palant

I have the distinct impression that Patchset 2 was uploaded to this review by mistake. ...

Aug. 21, 2013, 7:01 a.m. (2013-08-21 07:01:51 UTC) #5

Oleksandr

Aug. 21, 2013, 7:05 a.m. (2013-08-21 07:05:57 UTC) #6

On 2013/08/21 07:01:51, Wladimir Palant wrote:
> I have the distinct impression that Patchset 2 was uploaded to this review by
> mistake. See nit below concerning it.
> 
> LGTM on Patchset 3.
> 
>
http://codereview.adblockplus.org/11369200/diff/6001/src/plugin/PluginClass.cpp
> File src/plugin/PluginClass.cpp (right):
> 
>
http://codereview.adblockplus.org/11369200/diff/6001/src/plugin/PluginClass.c...
> src/plugin/PluginClass.cpp:1011: delete []pData;
> I don't think this change was intentional, please revert.


You're right. That is IE6 fix, it should not be here. I'll delete the patchset
#2 here and close the review request

Expand All Messages | Collapse All Messages