Issue 11376067: Fix updating

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11376067: Fix updating (Closed)

Created:
Aug. 8, 2013, 9:56 a.m. by Felix Dahlke

Modified:
Aug. 15, 2013, 2:35 p.m.

Reviewers:
Oleksandr, Wladimir Palant

Visibility:
Public.

Description

This fixes an issue I introduced in http://codereview.adblockplus.org/11304082/

Patch Set 1 #

Total comments: 1

Created: Aug. 8, 2013, 9:56 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -8 lines)			Patch
M	src/engine/Main.cpp	View	5 chunks	+6 lines, -5 lines	1 comment	Download
M	src/engine/Updater.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/engine/Updater.cpp	View	1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Wladimir Palant

LGTM but I would like the API cleanup indicated below to happen nevertheless (can happen ...

Aug. 13, 2013, 9:24 a.m. (2013-08-13 09:24:39 UTC) #3

Felix Dahlke

Aug. 15, 2013, 2:35 p.m. (2013-08-15 14:35:34 UTC) #4

On 2013/08/13 09:24:39, Wladimir Palant wrote:
> LGTM but I would like the API cleanup indicated below to happen nevertheless
> (can happen after the release).
> 
> http://codereview.adblockplus.org/11376067/diff/1/src/engine/Main.cpp
> File src/engine/Main.cpp (right):
> 
>
http://codereview.adblockplus.org/11376067/diff/1/src/engine/Main.cpp#newcode302
> src/engine/Main.cpp:302: updater->Update();
> updater->Update(params[0]->AsString()) would make more sense IMHO.

I was wondering what's better, that or making it explicit that the URL is part
of the state with a setter. Don't have a strong opinion, so I went with passing
the parameter to Update():

https://hg.adblockplus.org/adblockplusie/rev/55b8a17d1631

Expand All Messages | Collapse All Messages