Shut down the engine when the last tab is closed

To make this possible, I had to keep the pipe connections open for each client
instead of reconnecting for every single request. This change alone is worth
merging, since it appears to speed things up.

[Felix Dahlke, 2013-08-07 13:20:39]

To make this possible, I had to keep the pipe connections open for each client
instead of reconnecting for every single request. This change alone is worth
merging, since it appears to speed things up.

[Oleksandr, 2013-08-08 06:26:24]

On 2013/08/07 13:20:39, Felix H. Dahlke wrote:
> To make this possible, I had to keep the pipe connections open for each client
> instead of reconnecting for every single request. This change alone is worth
> merging, since it appears to speed things up.

LGTM in general

[Oleksandr, 2013-08-08 06:26:31]

http://codereview.adblockplus.org/11430025/diff/3001/src/plugin/AdblockPlusCl...
File src/plugin/AdblockPlusClient.cpp (right):

http://codereview.adblockplus.org/11430025/diff/3001/src/plugin/AdblockPlusCl...
src/plugin/AdblockPlusClient.cpp:119: enginePipe.reset(OpenEnginePipe());
Might it make sense to have some sort of a thread lock here for enginePipe?
shared_ptr is thread safe, but reassigning memory isn't.
http://stackoverflow.com/questions/14482830/stdshared-ptr-thread-safety

[Felix Dahlke, 2013-08-08 08:32:51]

http://codereview.adblockplus.org/11430025/diff/3001/src/plugin/AdblockPlusCl...
File src/plugin/AdblockPlusClient.cpp (right):

http://codereview.adblockplus.org/11430025/diff/3001/src/plugin/AdblockPlusCl...
src/plugin/AdblockPlusClient.cpp:119: enginePipe.reset(OpenEnginePipe());
On 2013/08/08 06:26:31, Oleksandr wrote:
> Might it make sense to have some sort of a thread lock here for enginePipe?
> shared_ptr is thread safe, but reassigning memory isn't.
> http://stackoverflow.com/questions/14482830/stdshared-ptr-thread-safety

Do we use a single CAdblockPlusClient instance from multiple threads? Doesn't
look like that. In that case we'd have a whole bunch of thread safety issues
here.

[Felix Dahlke, 2013-08-08 09:51:00]

Found an issue, these changes make the Updater hang. Will fix that first.

[Felix Dahlke, 2013-08-08 13:46:47]

Uploaded a new patch set. Now we're using the engine in a thread safe way, which
incidentally also fixes the hanging during update.

[Oleksandr, 2013-08-08 13:56:43]

On 2013/08/08 13:46:47, Felix H. Dahlke wrote:
> Uploaded a new patch set. Now we're using the engine in a thread safe way,
which
> incidentally also fixes the hanging during update.

LGTM #2

[Wladimir Palant, 2013-08-13 09:32:33]

LGTM