Issue 11464069: Set up statistics master server

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11464069: Set up statistics master server (Closed)

Created:
Aug. 23, 2013, 3:47 p.m. by Wladimir Palant

Modified:
Nov. 8, 2013, 8:07 a.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: Aug. 23, 2013, 3:47 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+239 lines, -36 lines)			Patch
M	Vagrantfile	View	2 chunks	+4 lines, -3 lines	1 comment	Download
M	manifests/monitoringserver.pp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	manifests/nodes.pp	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	manifests/statsmaster.pp	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	manifests/vagrant.pp	View	1 chunk	+8 lines, -4 lines	0 comments	Download
R	modules/private-stub/files/adblock@adblockplus.org.pub	View	1 chunk	+0 lines, -1 line	0 comments	Download
R	modules/private-stub/files/id_rsa	View	1 chunk	+0 lines, -27 lines	0 comments	Download
M	modules/private-stub/files/stats-authorized_keys	View	1 chunk	+1 line, -1 line	0 comments	Download
A	modules/private-stub/files/stats-htpasswd	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	modules/private-stub/files/stats@stats.adblockplus.org	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	modules/statsmaster/files/known_hosts	View	1 chunk	+17 lines, -0 lines	0 comments	Download
A	modules/statsmaster/files/logrotate	View	1 chunk	+11 lines, -0 lines	0 comments	Download
A	modules/statsmaster/files/sitescripts.ini	View	1 chunk	+30 lines, -0 lines	0 comments	Download
A	modules/statsmaster/files/stats.adblockplus.org	View	1 chunk	+43 lines, -0 lines	1 comment	Download
A	modules/statsmaster/manifests/init.pp	View	1 chunk	+115 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Felix Dahlke

LGTM, with some traditional nit picking. http://codereview.adblockplus.org/11464069/diff/1/Vagrantfile File Vagrantfile (left): http://codereview.adblockplus.org/11464069/diff/1/Vagrantfile#oldcode29 Vagrantfile:29: define_standard_vm config, 'server1', ...

Aug. 29, 2013, 2:20 p.m. (2013-08-29 14:20:45 UTC) #2

Wladimir Palant

Aug. 29, 2013, 8:10 p.m. (2013-08-29 20:10:32 UTC) #3

The nit has been addressed in http://codereview.adblockplus.org/11468051/.

Expand All Messages | Collapse All Messages