Update stats processing

The new stats processing scripts can process the stats for all our download servers - I updated the configuration and moved it into a separate module

[Wladimir Palant, 2013-08-23 14:01:38]

http://codereview.adblockplus.org/11468051/diff/1/Vagrantfile
File Vagrantfile (right):

http://codereview.adblockplus.org/11468051/diff/1/Vagrantfile#newcode6
Vagrantfile:6: config.vm.network :hostonly, ip, { nic_type: '82543GC' }
Not sure why but the other network interface doesn't work for me after updating
VirtualBox.

http://codereview.adblockplus.org/11468051/diff/1/modules/statsclient/manifes...
File modules/statsclient/manifests/init.pp (right):

http://codereview.adblockplus.org/11468051/diff/1/modules/statsclient/manifes...
modules/statsclient/manifests/init.pp:45: package {'python-jinja2':}
The log processor doesn't really need Jinja2. However, it uses the name of Gecko
application IDs from buildtools and buildtools depends on Jinja2. :-(

[Felix Dahlke, 2013-08-28 14:43:32]

LGTM with one remark, feel free to address it or not.

http://codereview.adblockplus.org/11468051/diff/1/modules/statsclient/manifes...
File modules/statsclient/manifests/init.pp (right):

http://codereview.adblockplus.org/11468051/diff/1/modules/statsclient/manifes...
modules/statsclient/manifests/init.pp:45: package {'python-jinja2':}
On 2013/08/23 14:01:38, Wladimir Palant wrote:
> The log processor doesn't really need Jinja2. However, it uses the name of
Gecko
> application IDs from buildtools and buildtools depends on Jinja2. :-(

Did you know that you can require multiple packages in a single line? We tend to
do that:

package {['python-geoip', 'python-simplejson', 'python-jinja2']:}

Also, I'm not entirely sure if the default value for ensure is "present". But if
it works, it's fine I guess.

[Wladimir Palant, 2013-08-29 20:10:07]

I've addressed that remark and the nit from
http://codereview.adblockplus.org/11464069/ in a new patch. I've also updated
everything for the changes in http://codereview.adblockplus.org/11577044/.

[Felix Dahlke, 2013-08-29 20:23:25]

LGTM, just one question

http://codereview.adblockplus.org/11468051/diff/6001/modules/statsclient/mani...
File modules/statsclient/manifests/init.pp (right):

http://codereview.adblockplus.org/11468051/diff/6001/modules/statsclient/mani...
modules/statsclient/manifests/init.pp:41: package {['pypy', 'python-jinja2']:}
Since we're using PyPy now, don't we need Jinja2 for PyPy?

[Wladimir Palant, 2013-08-29 21:02:31]

http://codereview.adblockplus.org/11468051/diff/6001/modules/statsclient/mani...
File modules/statsclient/manifests/init.pp (right):

http://codereview.adblockplus.org/11468051/diff/6001/modules/statsclient/mani...
modules/statsclient/manifests/init.pp:41: package {['pypy', 'python-jinja2']:}
On 2013/08/29 20:23:25, Felix H. Dahlke wrote:
> Since we're using PyPy now, don't we need Jinja2 for PyPy?

Yes :-(
I realized that this only worked because I tested with notifications log file -
that one doesn't have any app IDs.

[Wladimir Palant, 2013-08-29 21:07:39]

https://hg.adblockplus.org/buildtools/rev/16b4def8255f allowed dropping Jinja2
requirement here.

[Felix Dahlke, 2013-08-29 21:11:30]

LGTM