Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(72)

Issue 11588009: Support of gzip, deflate added to WinInet web request implementation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 11 months ago by Oleksandr
Modified:
5 years, 10 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Support of gzip, deflate added to WinInet web request implementation

Patch Set 1 #

Total comments: 3

Patch Set 2 : Use WinInet instead of WinHTTP #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -90 lines) Patch
M libadblockplus.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/DefaultWebRequestWinInet.cpp View 1 15 chunks +28 lines, -89 lines 3 comments Download

Messages

Total messages: 5
Oleksandr
http://codereview.adblockplus.org/11588009/diff/1/src/DefaultWebRequestWinInet.cpp File src/DefaultWebRequestWinInet.cpp (right): http://codereview.adblockplus.org/11588009/diff/1/src/DefaultWebRequestWinInet.cpp#newcode289 src/DefaultWebRequestWinInet.cpp:289: if (ver.dwMinorVersion == 1) No compression for IE6 (HTTP ...
5 years, 11 months ago (2013-09-03 11:49:41 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/11588009/diff/1/src/DefaultWebRequestWinInet.cpp File src/DefaultWebRequestWinInet.cpp (right): http://codereview.adblockplus.org/11588009/diff/1/src/DefaultWebRequestWinInet.cpp#newcode288 src/DefaultWebRequestWinInet.cpp:288: WinHttpQueryOption(NULL, WINHTTP_OPTION_HTTP_VERSION, (void*)&ver, &l); Nit: explicit conversion to void* ...
5 years, 11 months ago (2013-09-04 07:21:24 UTC) #2
Oleksandr
http://codereview.adblockplus.org/11588009/diff/6001/src/DefaultWebRequestWinInet.cpp File src/DefaultWebRequestWinInet.cpp (right): http://codereview.adblockplus.org/11588009/diff/6001/src/DefaultWebRequestWinInet.cpp#newcode228 src/DefaultWebRequestWinInet.cpp:228: res = InternetSetOption(hRequest, INTERNET_OPTION_HTTP_DECODING, &b, sizeof(b)); This is a ...
5 years, 10 months ago (2013-10-07 21:36:18 UTC) #3
Wladimir Palant
I assume that these changes pass the unit tests? LGTM with the two nits addressed. ...
5 years, 10 months ago (2013-10-08 07:24:28 UTC) #4
Oleksandr
5 years, 10 months ago (2013-10-08 07:52:23 UTC) #5

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5