Support of gzip, deflate added to WinInet web request implementation

Support of gzip, deflate added to WinInet web request implementation

[Oleksandr, 2013-09-03 11:49:41]

http://codereview.adblockplus.org/11588009/diff/1/src/DefaultWebRequestWinIne...
File src/DefaultWebRequestWinInet.cpp (right):

http://codereview.adblockplus.org/11588009/diff/1/src/DefaultWebRequestWinIne...
src/DefaultWebRequestWinInet.cpp:289: if (ver.dwMinorVersion == 1)
No compression for IE6 (HTTP 1.0)

[Wladimir Palant, 2013-09-04 07:21:24]

http://codereview.adblockplus.org/11588009/diff/1/src/DefaultWebRequestWinIne...
File src/DefaultWebRequestWinInet.cpp (right):

http://codereview.adblockplus.org/11588009/diff/1/src/DefaultWebRequestWinIne...
src/DefaultWebRequestWinInet.cpp:288: WinHttpQueryOption(NULL,
WINHTTP_OPTION_HTTP_VERSION, (void*)&ver, &l);
Nit: explicit conversion to void* is unnecessary IMHO.

http://codereview.adblockplus.org/11588009/diff/1/src/DefaultWebRequestWinIne...
src/DefaultWebRequestWinInet.cpp:289: if (ver.dwMinorVersion == 1)
I don't like hardcoding the expectation here that there are exactly two HTTP
versions (yes, regardless of what the documentation says). How about checking
that version is at least HTTP 1.1?

if (ver.dwMajorVersion > 1 || (ver.dwMajorVersion == 1 && ver.dwMinorVersion >=
1))

Also, from what I can tell IE6 doesn't generally use HTTP 1.0 - only when it is
behind a proxy.

[Oleksandr, 2013-10-07 21:36:18]

http://codereview.adblockplus.org/11588009/diff/6001/src/DefaultWebRequestWin...
File src/DefaultWebRequestWinInet.cpp (right):

http://codereview.adblockplus.org/11588009/diff/6001/src/DefaultWebRequestWin...
src/DefaultWebRequestWinInet.cpp:228: res = InternetSetOption(hRequest,
INTERNET_OPTION_HTTP_DECODING, &b, sizeof(b));
This is a key change. Since WinHTTP does not support gzip compression I had to
move to WinInet to use this.

[Wladimir Palant, 2013-10-08 07:24:28]

I assume that these changes pass the unit tests?

LGTM with the two nits addressed. Please don't push yet however, this is too
late for the release today.

http://codereview.adblockplus.org/11588009/diff/6001/src/DefaultWebRequestWin...
File src/DefaultWebRequestWinInet.cpp (right):

http://codereview.adblockplus.org/11588009/diff/6001/src/DefaultWebRequestWin...
src/DefaultWebRequestWinInet.cpp:27: class WinHttpHandle
It would probably make sense to rename this class into WinInetHandle?

http://codereview.adblockplus.org/11588009/diff/6001/src/DefaultWebRequestWin...
src/DefaultWebRequestWinInet.cpp:208: }
Am I missing something or is this if block completely superfluous? You do
exactly the same thing, whether isSecure is set or not.