Fix ATL assertion error in traverser

Fix ATL assertion error in traverser

[Wladimir Palant, 2013-10-08 10:30:37]

http://codereview.adblockplus.org/12325013/diff/1/src/plugin/PluginFilter.cpp
File src/plugin/PluginFilter.cpp (right):

http://codereview.adblockplus.org/12325013/diff/1/src/plugin/PluginFilter.cpp...
src/plugin/PluginFilter.cpp:398: pPrevSiblingNode.Attach(tmpNode);
For reference: this is the only place that needed to be changed, the rest is
just cleanup.

http://codereview.adblockplus.org/12325013/diff/1/src/plugin/PluginFilter.cpp...
src/plugin/PluginFilter.cpp:411: }
I think that the logic here is still unnecessarily complicated, the outer if
block is unnecessary:

CComQIPtr<IHTMLDOMNode> pPrevSiblingNode = pEl;
long type = 0;
while (pPrevSiblingNode && type != 1)
{
  ... move up from pPrevSiblingNode ...
}

if (pPrevSiblingNode)
  hr = pPrevSiblingNode.QueryInterface();
else
  return false;

[Felix Dahlke, 2013-10-10 08:52:45]

LGTM

http://codereview.adblockplus.org/12325013/diff/1/src/plugin/PluginFilter.cpp
File src/plugin/PluginFilter.cpp (right):

http://codereview.adblockplus.org/12325013/diff/1/src/plugin/PluginFilter.cpp...
src/plugin/PluginFilter.cpp:411: }
On 2013/10/08 10:30:38, Wladimir Palant wrote:
> I think that the logic here is still unnecessarily complicated, the outer if
> block is unnecessary:
> 
> CComQIPtr<IHTMLDOMNode> pPrevSiblingNode = pEl;
> long type = 0;
> while (pPrevSiblingNode && type != 1)
> {
>   ... move up from pPrevSiblingNode ...
> }
> 
> if (pPrevSiblingNode)
>   hr = pPrevSiblingNode.QueryInterface();
> else
>   return false;

Yes, that'd be better.

[Wladimir Palant, 2013-10-16 09:44:23]

LGTM

[Felix Dahlke, 2013-10-16 09:59:02]

LGTM