Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/content/tests/prefs.js

Issue 12783007: Fixed: String pref test failed due to default value differing across platforms (Closed)
Patch Set: Created Oct. 10, 2013, 11:06 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/content/tests/prefs.js
===================================================================
--- a/chrome/content/tests/prefs.js
+++ b/chrome/content/tests/prefs.js
@@ -81,15 +81,15 @@
test("String pref", function()
{
- Prefs.data_directory = "adblockplus";
- equal(Prefs.data_directory, "adblockplus", "Prefs object returns the correct value after setting pref to default value");
- equal(prefExists("data_directory"), false, "User-defined pref has been removed");
+ Prefs.notificationurl = "https://notification.adblockplus.org/notification.json";
Wladimir Palant 2013/10/10 12:16:29 Please declare that value as a variable: var defa
+ equal(Prefs.notificationurl, "https://notification.adblockplus.org/notification.json", "Prefs object returns the correct value after setting pref to default value");
+ equal(prefExists("notificationurl"), false, "User-defined pref has been removed");
- let newValue = "foo\u1234bar";
- Prefs.data_directory = newValue;
- equal(Prefs.data_directory, newValue, "Prefs object returns the correct value after setting pref to non-default value");
- equal(prefExists("data_directory"), true, "User-defined pref has been created");
- checkPref("data_directory", newValue, "Value has been written");
+ let newValue = "https://notification.adblockplus.org/foo\u1234bar.json";
+ Prefs.notificationurl = newValue;
+ equal(Prefs.notificationurl, newValue, "Prefs object returns the correct value after setting pref to non-default value");
+ equal(prefExists("notificationurl"), true, "User-defined pref has been created");
+ checkPref("notificationurl", newValue, "Value has been written");
});
test("Object pref (complete replacement)", function()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld