Issue 12836004: Fixed crash caused by update tooltips, TOOLINFO.hwnd cannot be thetooltip itself (causes a recursi…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12836004: Fixed crash caused by update tooltips, TOOLINFO.hwnd cannot be thetooltip itself (causes a recursi… (Closed)

Created:
Oct. 9, 2013, 5:44 a.m. by Wladimir Palant

Modified:
Oct. 10, 2013, 10:09 a.m.

Reviewers:
Felix Dahlke, Oleksandr

Visibility:
Public.

Description

See http://msdn.microsoft.com/en-us/library/windows/desktop/hh298405%28v=vs.85%29.aspx for an example of how TOOLINFO.hwnd should be used.

Patch Set 1 #

Created: Oct. 9, 2013, 5:44 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	src/plugin/NotificationMessage.cpp	View		3 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Felix Dahlke

LGTM, I think that's the correct wa to do it anyway.

Oct. 10, 2013, 8:32 a.m. (2013-10-10 08:32:27 UTC) #2

Oleksandr

Oct. 10, 2013, 10:09 a.m. (2013-10-10 10:09:45 UTC) #3

On 2013/10/10 08:32:27, Felix H. Dahlke wrote:
> LGTM, I think that's the correct wa to do it anyway.

Pretty sure setting it to parent did not work for me when I've been figuring it
out. But tested now and all is fine, so yeah.. LGTM.

Expand All Messages | Collapse All Messages