Issue 29321232: Issue 2732 - Update libadblockplus to revision d2f0f5396b5f

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29321232: Issue 2732 - Update libadblockplus to revision d2f0f5396b5f (Closed)

Created:
June 30, 2015, 12:33 a.m. by Oleksandr

Modified:
July 2, 2015, 10:24 a.m.

Reviewers:
sergei, Eric, Felix Dahlke

Visibility:
Public.

Description

Issue 2732 - Update libadblockplus to revision d2f0f5396b5f

Patch Set 1 #

Created: June 30, 2015, 12:33 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	dependencies	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Eric

This should be part of the change set for using ensure_dependencies. It makes no sense ...

July 1, 2015, 5:04 p.m. (2015-07-01 17:04:48 UTC) #2

Felix Dahlke

July 2, 2015, 10:02 a.m. (2015-07-02 10:02:36 UTC) #3

On 2015/07/01 17:04:48, Eric wrote:
> This should be part of the change set for using ensure_dependencies. It makes
no
> sense to alter it beforehand, and we want the new version as soon as possible.

I agree, let's merge both into issue 2732.

Expand All Messages | Collapse All Messages