Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29323528: Issue 2870 - Adjust icons on homepage horizontally (Closed)

Created:
Aug. 13, 2015, 2:51 a.m. by Oleksandr
Modified:
Oct. 7, 2015, 4:58 p.m.
Reviewers:
saroyanm
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 2870 - Adjust icons on homepage horizontally

Patch Set 1 #

Total comments: 3

Patch Set 2 : Addressing comments #

Patch Set 3 : Rebased to the current tip #

Patch Set 4 : Rebased to #2844. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M static/css/index-desktop.css View 1 2 3 4 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 9
Oleksandr
Aug. 13, 2015, 4:16 a.m. (2015-08-13 04:16:33 UTC) #1
saroyanm
On 2015/08/13 04:16:33, Oleksandr wrote: Can't apply patch, Seems like we have different source files, ...
Aug. 20, 2015, 7:08 p.m. (2015-08-20 19:08:06 UTC) #2
saroyanm
On 2015/08/13 04:16:33, Oleksandr wrote: Can't apply patch, Seems like we have different source files, ...
Aug. 20, 2015, 7:08 p.m. (2015-08-20 19:08:07 UTC) #3
saroyanm
https://codereview.adblockplus.org/29323528/diff/29323529/static/css/index-desktop.css File static/css/index-desktop.css (right): https://codereview.adblockplus.org/29323528/diff/29323529/static/css/index-desktop.css#newcode74 static/css/index-desktop.css:74: margin: 30px 35px; I assume this fix belongs to ...
Aug. 20, 2015, 7:08 p.m. (2015-08-20 19:08:14 UTC) #4
saroyanm
https://codereview.adblockplus.org/29323528/diff/29323529/static/css/index-desktop.css File static/css/index-desktop.css (right): https://codereview.adblockplus.org/29323528/diff/29323529/static/css/index-desktop.css#newcode51 static/css/index-desktop.css:51: bottom: -30px; With current layout we shouldn't position button ...
Aug. 20, 2015, 7:13 p.m. (2015-08-20 19:13:35 UTC) #5
saroyanm
https://codereview.adblockplus.org/29323528/diff/29323529/static/css/index-desktop.css File static/css/index-desktop.css (right): https://codereview.adblockplus.org/29323528/diff/29323529/static/css/index-desktop.css#newcode51 static/css/index-desktop.css:51: bottom: -30px; On 2015/08/20 19:13:35, saroyanm wrote: > With ...
Aug. 20, 2015, 8:37 p.m. (2015-08-20 20:37:07 UTC) #6
Oleksandr
Aug. 26, 2015, 12:55 a.m. (2015-08-26 00:55:14 UTC) #7
Oleksandr
Rebased. Please note that this patch set builds on top of https://codereview.adblockplus.org/29322769/, so you'll have ...
Sept. 21, 2015, 11:12 p.m. (2015-09-21 23:12:22 UTC) #8
Oleksandr
Oct. 2, 2015, 1:07 a.m. (2015-10-02 01:07:30 UTC) #9

          

Powered by Google App Engine
This is Rietveld