Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29325436: Issue 1281 - Introduce module buildbot (Closed)

Created:
Sept. 1, 2015, 1:30 p.m. by mathias
Modified:
Feb. 20, 2016, 1:25 p.m.
Reviewers:
Felix Dahlke
CC:
Fred
Visibility:
Public.

Description

Issue 1281 - Introduce module buildbot

Patch Set 1 #

Patch Set 2 : Issue 1281 - Rebase branch buildbot on top of upstream #

Total comments: 40

Patch Set 3 : Issue 1281 - Address review feedback #

Total comments: 26

Patch Set 4 : Issue 1281 - Fix documentation, improve configuration parameter handling #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+722 lines, -1 line) Patch
A hiera/roles/buildmasterserver.yaml View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
A + modules/adblockplus/files/nginx/buildmaster.conf View 1 2 1 chunk +3 lines, -1 line 0 comments Download
A modules/adblockplus/manifests/buildmaster.pp View 1 2 3 1 chunk +87 lines, -0 lines 0 comments Download
A modules/adblockplus/templates/buildmaster.erb View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
A modules/buildbot/manifests/fragment.pp View 1 chunk +50 lines, -0 lines 0 comments Download
A modules/buildbot/manifests/init.pp View 1 2 1 chunk +123 lines, -0 lines 0 comments Download
A modules/buildbot/manifests/master.pp View 1 2 3 1 chunk +145 lines, -0 lines 0 comments Download
A modules/buildbot/manifests/slave.pp View 1 2 3 1 chunk +110 lines, -0 lines 0 comments Download
A modules/buildbot/templates/buildmaster.erb View 1 chunk +16 lines, -0 lines 0 comments Download
A modules/buildbot/templates/buildmaster_fragment.erb View 1 chunk +9 lines, -0 lines 0 comments Download
A modules/buildbot/templates/buildslave.erb View 1 chunk +16 lines, -0 lines 0 comments Download
A modules/buildbot/templates/buildslave_fragment.erb View 1 chunk +9 lines, -0 lines 0 comments Download
A modules/buildbot/templates/master.cfg.erb View 1 2 3 1 chunk +132 lines, -0 lines 3 comments Download
M modules/private-stub/hiera/hosts.yaml View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 20
mathias
Sept. 1, 2015, 1:30 p.m. (2015-09-01 13:30:38 UTC) #1
mathias
Sept. 5, 2015, 11:27 p.m. (2015-09-05 23:27:45 UTC) #2
Felix Dahlke
Just looked at the first few files so far. I won't be able to look ...
Sept. 29, 2015, 2:04 p.m. (2015-09-29 14:04:22 UTC) #3
mathias
(I will update the acknowledged parts accordingly after your first review has finished.) https://codereview.adblockplus.org/29325436/diff/29326009/hiera/roles/buildserver.yaml File ...
Sept. 29, 2015, 2:18 p.m. (2015-09-29 14:18:57 UTC) #4
Felix Dahlke
Here go some more comments. Now I only need to look at master.pp, slave.pp and ...
Oct. 2, 2015, 12:16 p.m. (2015-10-02 12:16:27 UTC) #5
Felix Dahlke
OK, now I'm finished. Did a rather high level review, but assuming it works, looks ...
Oct. 2, 2015, 12:39 p.m. (2015-10-02 12:39:43 UTC) #6
mathias
On 2015/10/02 12:39:43, Felix Dahlke wrote: > So did I understand that correctly that, for ...
Oct. 2, 2015, 1:47 p.m. (2015-10-02 13:47:41 UTC) #7
Felix Dahlke
https://codereview.adblockplus.org/29325436/diff/29326009/modules/buildbot/manifests/init.pp File modules/buildbot/manifests/init.pp (right): https://codereview.adblockplus.org/29325436/diff/29326009/modules/buildbot/manifests/init.pp#newcode65 modules/buildbot/manifests/init.pp:65: class buildbot ( On 2015/10/02 13:47:40, mathias wrote: > ...
Oct. 2, 2015, 3:44 p.m. (2015-10-02 15:44:27 UTC) #8
mathias
https://codereview.adblockplus.org/29325436/diff/29326009/modules/buildbot/manifests/init.pp File modules/buildbot/manifests/init.pp (right): https://codereview.adblockplus.org/29325436/diff/29326009/modules/buildbot/manifests/init.pp#newcode65 modules/buildbot/manifests/init.pp:65: class buildbot ( > Oh, now I get it, ...
Oct. 2, 2015, 4:25 p.m. (2015-10-02 16:25:54 UTC) #9
Felix Dahlke
https://codereview.adblockplus.org/29325436/diff/29326009/modules/buildbot/manifests/init.pp File modules/buildbot/manifests/init.pp (right): https://codereview.adblockplus.org/29325436/diff/29326009/modules/buildbot/manifests/init.pp#newcode65 modules/buildbot/manifests/init.pp:65: class buildbot ( On 2015/10/02 16:25:53, mathias wrote: > ...
Oct. 2, 2015, 4:48 p.m. (2015-10-02 16:48:48 UTC) #10
mathias
Issue 1281 - Migrate unused parameters to class variables Issue 1281 - Rename $buildbot::master::{slots => ...
Oct. 20, 2015, 8:35 p.m. (2015-10-20 20:35:58 UTC) #11
mathias
https://codereview.adblockplus.org/29325436/diff/29326009/modules/buildbot/manifests/init.pp File modules/buildbot/manifests/init.pp (right): https://codereview.adblockplus.org/29325436/diff/29326009/modules/buildbot/manifests/init.pp#newcode65 modules/buildbot/manifests/init.pp:65: class buildbot ( On 2015/10/02 16:48:48, Felix Dahlke wrote: ...
Oct. 20, 2015, 8:36 p.m. (2015-10-20 20:36:17 UTC) #12
Felix Dahlke
Sorry for the delay, here's another round of comments/questions! https://codereview.adblockplus.org/29325436/diff/29329287/hiera/roles/buildmasterserver.yaml File hiera/roles/buildmasterserver.yaml (right): https://codereview.adblockplus.org/29325436/diff/29329287/hiera/roles/buildmasterserver.yaml#newcode3 hiera/roles/buildmasterserver.yaml:3: ...
Nov. 19, 2015, 7:50 p.m. (2015-11-19 19:50:02 UTC) #13
mathias
Jan. 20, 2016, 4:13 p.m. (2016-01-20 16:13:27 UTC) #14
mathias
https://codereview.adblockplus.org/29325436/diff/29329287/hiera/roles/buildmasterserver.yaml File hiera/roles/buildmasterserver.yaml (right): https://codereview.adblockplus.org/29325436/diff/29329287/hiera/roles/buildmasterserver.yaml#newcode3 hiera/roles/buildmasterserver.yaml:3: domain: buildbot.adblockplus.org On 2015/11/19 19:50:00, Felix Dahlke wrote: > ...
Jan. 20, 2016, 4:13 p.m. (2016-01-20 16:13:53 UTC) #15
Felix Dahlke
Did more of a high level review now, looks good mostly. Just two comments at ...
Feb. 10, 2016, 9:26 a.m. (2016-02-10 09:26:11 UTC) #16
mathias
New patch-set will follow soon. https://codereview.adblockplus.org/29325436/diff/29329287/modules/buildbot/templates/master.cfg.erb File modules/buildbot/templates/master.cfg.erb (right): https://codereview.adblockplus.org/29325436/diff/29329287/modules/buildbot/templates/master.cfg.erb#newcode123 modules/buildbot/templates/master.cfg.erb:123: c['buildbotURL'] = 'http://localhost:<%= @http_port.to_i ...
Feb. 10, 2016, 10:30 a.m. (2016-02-10 10:30:46 UTC) #17
Felix Dahlke
https://codereview.adblockplus.org/29325436/diff/29329287/modules/buildbot/templates/master.cfg.erb File modules/buildbot/templates/master.cfg.erb (right): https://codereview.adblockplus.org/29325436/diff/29329287/modules/buildbot/templates/master.cfg.erb#newcode123 modules/buildbot/templates/master.cfg.erb:123: c['buildbotURL'] = 'http://localhost:<%= @http_port.to_i %>/' On 2016/02/10 10:30:45, mathias ...
Feb. 10, 2016, 11:54 a.m. (2016-02-10 11:54:41 UTC) #18
mathias
https://codereview.adblockplus.org/29325436/diff/29329287/modules/buildbot/templates/master.cfg.erb File modules/buildbot/templates/master.cfg.erb (right): https://codereview.adblockplus.org/29325436/diff/29329287/modules/buildbot/templates/master.cfg.erb#newcode123 modules/buildbot/templates/master.cfg.erb:123: c['buildbotURL'] = 'http://localhost:<%= @http_port.to_i %>/' On 2016/02/10 11:54:39, Felix ...
Feb. 18, 2016, 10:54 a.m. (2016-02-18 10:54:43 UTC) #19
Felix Dahlke
Feb. 18, 2016, 7:48 p.m. (2016-02-18 19:48:48 UTC) #20
LGTM

Powered by Google App Engine
This is Rietveld