Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29326068: Issue 2823 - Attach parent subscription types when parsing supplemental subscriptions (Closed)

Created:
Sept. 8, 2015, 9:44 a.m. by Thomas Greiner
Modified:
Sept. 9, 2015, 12:13 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

This change turned out to be necessary to implement #2823 and thereby also fix #2994. I decided to introduce a new property to assure backwards compatibility. Let me know whether you prefer including the subscription objects instead of just their types in that property. See Website changes: https://codereview.adblockplus.org/29326085/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M sitescripts/subscriptions/subscriptionParser.py View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Thomas Greiner
Sept. 8, 2015, 10:20 a.m. (2015-09-08 10:20:12 UTC) #1
Sebastian Noack
Sept. 8, 2015, 12:45 p.m. (2015-09-08 12:45:09 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld