Issue 29328882: Issue 2870 - Adjust icons on homepage horizontally

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29328882: Issue 2870 - Adjust icons on homepage horizontally (Closed)

Created:
Oct. 6, 2015, 4:03 p.m. by saroyanm

Modified:
Nov. 2, 2015, 9:30 a.m.

Reviewers:
Oleksandr

CC:
Felix Dahlke

Visibility:
Public.

Description

This issue also contains small changes that was related to #2844, but while the review for #2844 was somehow connected to the changes I've decided to make that changes here, so the layout will not look broken and inconsistent, further cosmetic changes will follow for Edge page, with separate review.

Patch Set 1 #

Total comments: 1

Created: Oct. 6, 2015, 4:03 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -75 lines)			Patch
M	includes/index.tmpl	View	1 chunk	+33 lines, -30 lines	1 comment	Download
M	static/css/index.css	View	5 chunks	+8 lines, -17 lines	0 comments	Download
M	static/css/index-desktop.css	View	4 chunks	+13 lines, -26 lines	0 comments	Download
M	static/css/index-mobile.css	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Oleksandr

Oct. 7, 2015, 9:26 a.m. (2015-10-07 09:26:38 UTC) #2

Just one nit. LGTM.

https://codereview.adblockplus.org/29328882/diff/29328883/includes/index.tmpl
File includes/index.tmpl (right):

https://codereview.adblockplus.org/29328882/diff/29328883/includes/index.tmpl...
includes/index.tmpl:102: <div>{{"Download Adblock Plus for another
browser:"|translate("other-browsers")}}</div>
Nit: It might make sense to rename the translation to "other-platform" as well.

Expand All Messages | Collapse All Messages