Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29329510: Issue #1186 - Style conformity for names in installer tests (Closed)

Created:
Oct. 29, 2015, 7:26 p.m. by Eric
Modified:
Nov. 17, 2015, 7:14 p.m.
Reviewers:
Oleksandr
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue #1186 - Style conformity for names in installer tests Changed names in installer tests to conform to camel case style. A few other typos tagged along.

Patch Set 1 #

Total comments: 9

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -134 lines) Patch
M installer/src/custom-action/close_application.cpp View 1 chunk +1 line, -1 line 0 comments Download
M installer/src/installer-lib/process.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M installer/src/installer-lib/property.cpp View 1 chunk +1 line, -1 line 0 comments Download
M installer/src/installer-lib/test/custom-action-fail.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M installer/src/installer-lib/test/database_test.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M installer/src/installer-lib/test/exception_test.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M installer/src/installer-lib/test/process_test.cpp View 1 12 chunks +84 lines, -84 lines 0 comments Download
M installer/src/installer-lib/test/property_test.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M installer/src/installer-lib/test/test-installer-lib-ca.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M installer/src/installer-lib/test/test-installer-lib-sandbox.cpp View 1 5 chunks +24 lines, -24 lines 0 comments Download

Messages

Total messages: 4
Eric
This is the last of the installer style changes.
Oct. 29, 2015, 7:30 p.m. (2015-10-29 19:30:33 UTC) #1
Oleksandr
Just a few nits, which are all related, really. https://codereview.adblockplus.org/29329510/diff/29329511/installer/src/installer-lib/test/process_test.cpp File installer/src/installer-lib/test/process_test.cpp (right): https://codereview.adblockplus.org/29329510/diff/29329511/installer/src/installer-lib/test/process_test.cpp#newcode17 installer/src/installer-lib/test/process_test.cpp:17: ...
Oct. 29, 2015, 11:26 p.m. (2015-10-29 23:26:23 UTC) #2
Eric
New patch set fixes all comments plus some others I found in the process. https://codereview.adblockplus.org/29329510/diff/29329511/installer/src/installer-lib/test/process_test.cpp ...
Nov. 14, 2015, 6:01 p.m. (2015-11-14 18:01:08 UTC) #3
Oleksandr
Nov. 15, 2015, 11:43 p.m. (2015-11-15 23:43:26 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld