Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29330625: Issue #1234 - Remove CString from PluginWbPassThrough.* (Closed)

Created:
Nov. 20, 2015, 8:07 p.m. by Eric
Modified:
Nov. 25, 2015, 4:07 p.m.
Reviewers:
sergei, Oleksandr
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue #1234 - Remove CString from PluginWbPassThrough.* Converted all occurrences of 'CString' to 'wstring' in PluginWbPassThrough.*. Also fixed indentation in these files, replacing all tab characters. Changed a handful of member functions of 'WBPassthruSink' to private.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -60 lines) Patch
M src/plugin/PluginWbPassThrough.h View 2 chunks +47 lines, -44 lines 0 comments Download
M src/plugin/PluginWbPassThrough.cpp View 5 chunks +14 lines, -16 lines 0 comments Download

Messages

Total messages: 3
Eric
Nov. 20, 2015, 8:13 p.m. (2015-11-20 20:13:03 UTC) #1
Oleksandr
LGTM
Nov. 25, 2015, 3:07 a.m. (2015-11-25 03:07:34 UTC) #2
sergei
Nov. 25, 2015, 8:31 a.m. (2015-11-25 08:31:42 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld