Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29330683: Issue #1486 - Move PassthroughAPP code to its own directory (Closed)

Created:
Nov. 23, 2015, 12:56 p.m. by Eric
Modified:
Nov. 25, 2015, 4:05 p.m.
Reviewers:
sergei, Oleksandr
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue #1486 - Move PassthroughAPP code to its own directory Move the current PassthroughAPP code into its own directory 'src/plugin/passthroughapp'. This is a preliminary change. The current code we have for PassthroughAPP is not fully third-party code at present. It's a combination of an older version plus our own modifications. After #1484 is done, we can complete #1486 and move it into 'third_party/passthroughapp'.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M adblockplus.gyp View 1 chunk +6 lines, -6 lines 0 comments Download
M src/plugin/PluginWbPassThrough.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/plugin/passthroughapp/ProtocolCF.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/plugin/passthroughapp/ProtocolCF.inl View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/plugin/passthroughapp/ProtocolImpl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/plugin/passthroughapp/ProtocolImpl.inl View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/plugin/passthroughapp/SinkPolicy.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/plugin/passthroughapp/SinkPolicy.inl View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 4
Eric
The review tool is showing "-1" lines changed for "0" lines changed for the renamed ...
Nov. 23, 2015, 1:02 p.m. (2015-11-23 13:02:21 UTC) #1
sergei
LGTM Eric wrote: > After #1484 is done, we can complete #1486 and move it ...
Nov. 23, 2015, 1:59 p.m. (2015-11-23 13:59:37 UTC) #2
Eric
On 2015/11/23 13:59:37, sergei wrote: > We can merge it now and then do #1484 ...
Nov. 23, 2015, 2:11 p.m. (2015-11-23 14:11:31 UTC) #3
Oleksandr
Nov. 24, 2015, 10:52 a.m. (2015-11-24 10:52:10 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld