Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(24)

Issue 29330709: Issue #3343 - Eliminate unescaping of URL (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by Eric
Modified:
4 years, 3 months ago
Reviewers:
sergei, Oleksandr
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue #3343 - Eliminate unescaping of URL Remove UnescapeUrl() and all calls to it.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Reverted unrelated defect introduction #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -46 lines) Patch
M src/plugin/AdblockPlusDomTraverser.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/plugin/PluginClass.cpp View 1 3 chunks +0 lines, -3 lines 0 comments Download
M src/plugin/PluginDomTraverserBase.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/plugin/PluginUtil.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/plugin/PluginUtil.cpp View 1 chunk +0 lines, -28 lines 0 comments Download
M src/plugin/PluginWbPassThrough.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 8
Eric
If we're going to stop unescaping URL's entirely, this is how you do it. I ...
4 years, 3 months ago (2015-11-23 14:18:51 UTC) #1
Oleksandr
I think this should definitely not be a "Noissue" commit. FYI: https://issues.adblockplus.org/ticket/3343
4 years, 3 months ago (2015-11-23 14:35:14 UTC) #2
Eric
On 2015/11/23 14:35:14, Oleksandr wrote: > I think this should definitely not be a "Noissue" ...
4 years, 3 months ago (2015-11-23 14:47:28 UTC) #3
Oleksandr
I don't think we can commit a changeset like this without an appropriate issue. I ...
4 years, 3 months ago (2015-11-25 02:24:29 UTC) #4
sergei
https://codereview.adblockplus.org/29330709/diff/29330710/src/plugin/PluginClass.cpp File src/plugin/PluginClass.cpp (right): https://codereview.adblockplus.org/29330709/diff/29330710/src/plugin/PluginClass.cpp#newcode490 src/plugin/PluginClass.cpp:490: if (url.find(L"javascript") == std::wstring::npos) On 2015/11/25 02:24:29, Oleksandr wrote: ...
4 years, 3 months ago (2015-11-25 08:29:14 UTC) #5
Eric
Changed the commit message to issue #3343. https://codereview.adblockplus.org/29330709/diff/29330710/src/plugin/PluginClass.cpp File src/plugin/PluginClass.cpp (right): https://codereview.adblockplus.org/29330709/diff/29330710/src/plugin/PluginClass.cpp#newcode490 src/plugin/PluginClass.cpp:490: if (url.find(L"javascript") ...
4 years, 3 months ago (2015-11-25 16:18:21 UTC) #6
Oleksandr
LGTM
4 years, 3 months ago (2015-11-25 17:31:46 UTC) #7
sergei
4 years, 3 months ago (2015-11-26 11:12:19 UTC) #8
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5