Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29331537: Noissue - Change argument of 'GetHtmlElementAttribute()' to 'std::wstring'

Created:
Nov. 29, 2015, 3:59 p.m. by Eric
Modified:
March 29, 2017, 12:32 p.m.
Reviewers:
sergei, Oleksandr
CC:
Felix Dahlke
Visibility:
Public.

Description

Noissue - Change argument of 'GetHtmlElementAttribute()' to 'std::wstring'

Patch Set 1 #

Patch Set 2 : rebase only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M src/engine/NotificationWindow.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/plugin/PluginFilter.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/shared/MsHTMLUtils.h View 1 chunk +1 line, -1 line 0 comments Download
M src/shared/MsHTMLUtils.cpp View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6
Eric
Nov. 29, 2015, 4:05 p.m. (2015-11-29 16:05:55 UTC) #1
Oleksandr
No objections here. Why does this depend on https://codereview.adblockplus.org/29331055/?
Jan. 31, 2016, 9:36 p.m. (2016-01-31 21:36:32 UTC) #2
Eric
On 2016/01/31 21:36:32, Oleksandr wrote: > No objections here. Why does this depend on > ...
Feb. 3, 2016, 6:13 p.m. (2016-02-03 18:13:26 UTC) #3
Eric
Patch set 2 is rebase only. Removed dependency on previous review now committed.
May 17, 2016, 7:42 p.m. (2016-05-17 19:42:42 UTC) #4
Oleksandr
LGTM
March 1, 2017, 3:48 p.m. (2017-03-01 15:48:15 UTC) #5
sergei
March 29, 2017, 12:32 p.m. (2017-03-29 12:32:33 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld