Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29331579: Issue #1484 - Remove unused argument from 'WBPassthruSink::OnStart' (Closed)

Created:
Nov. 30, 2015, 12:19 p.m. by Eric
Modified:
Dec. 2, 2015, 2:20 p.m.
Reviewers:
sergei, Oleksandr
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue #1484 - Remove unused argument from 'WBPassthruSink::OnStart' The argument 'handled' to 'WBPassthruSink::OnStart' was not referenced. Removing this argument brings this member function back to the same signature as defined in its base class 'PassthroughAPP::CInternetProtocolSinkWithSP'. The only reference to this argument as a local variable 'handled' in 'PassthroughAPP::CustomSinkStartPolicy::OnStart'. Removing this variable brings the code for this function closer to the original PassthroughAPP code. ----- This review is a dependency of the following one: https://codereview.adblockplus.org/29331590/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M src/plugin/PluginWbPassThrough.h View 1 chunk +1 line, -1 line 0 comments Download
M src/plugin/PluginWbPassThrough.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/plugin/passthroughapp/SinkPolicy.inl View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3
Eric
First of two reviews to fix #1484. This one should be obvious.
Nov. 30, 2015, 1:57 p.m. (2015-11-30 13:57:07 UTC) #1
sergei
LGTM
Nov. 30, 2015, 2:20 p.m. (2015-11-30 14:20:32 UTC) #2
Oleksandr
Dec. 1, 2015, 11:08 p.m. (2015-12-01 23:08:19 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld