Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29331713: TEST ONLY -- Verify behavior of DISP_E_BADINDEX in the IE JavaScript runtime (Closed)

Created:
Dec. 1, 2015, 5:48 p.m. by Eric
Modified:
Dec. 14, 2015, 11:17 a.m.
Reviewers:
sergei, Oleksandr
CC:
Felix Dahlke
Visibility:
Public.

Description

TEST ONLY -- Verify behavior of DISP_E_BADINDEX in the IE JavaScript runtime This change set is not intended to be committed. It's a live test of how the JavaScript engine in IE interprets DISP_E_BADINDEX when returned from our injected 'Settings' object. The result is that the statement throws an exception with message "Subscript out of range", and the 'name' property on its prototype object is "RangeError". The result: returning DISP_E_BADINDEX is fully supported by JavaScript in IE. ----- Add a test method to 'CPluginUserSettings' named "TestBadIndex". When passed zero, it returns normally, to verify that this method can be called. When passed any positive number, it returns DISP_E_BADINDEX. Add HTML and JS test files. The HTML test page is located in "html/templates" to ensure settings injection. ----- Informs the following review: https://codereview.adblockplus.org/29330798/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -0 lines) Patch
A html/templates/test-bad-index.html View 1 chunk +25 lines, -0 lines 0 comments Download
A html/templates/test-bad-index.js View 1 chunk +43 lines, -0 lines 0 comments Download
M src/plugin/PluginUserSettings.cpp View 3 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Eric
Dec. 1, 2015, 5:53 p.m. (2015-12-01 17:53:34 UTC) #1
Oleksandr
Have you tried this on older version of IE as well? We know that DISP_E_EXCEPTION ...
Dec. 3, 2015, 12:03 p.m. (2015-12-03 12:03:35 UTC) #2
Eric
Dec. 3, 2015, 1:37 p.m. (2015-12-03 13:37:00 UTC) #3
On 2015/12/03 12:03:35, Oleksandr wrote:
> Have you tried this on older version of IE as well?

No.

RangeError, however, has been in javascript for a long time. I can't find
anything on it being a compatibility problem on, say, quirksmode or caniuse. It
seems possible that Microsoft suddenly woke up for IE 9 and said "OMG we never
implemented RangeError for ActiveX!" but I really doubt that, since Microsoft's
original business strategy was to blunt the web by making it an ActiveX
container for corporate intranets.

Powered by Google App Engine
This is Rietveld