Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(331)

Issue 29332455: Issue #1596, #1720 - Make status bar menu consistent with plugin abilities (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 12 months ago by Eric
Modified:
3 years, 11 months ago
Reviewers:
Oleksandr, sergei
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue #1596, #1720 - Make status bar menu consistent with plugin abilities Add 'CPluginTab::IsPossibleToDisableOnSite()'. This function returns true if the tab document has protocol "http:" or "https:", the only protocols that ABP is able to intercept. Issue #1596 concerns protocol "about:"; issue #1720 concerns protocol "file:". Add condition to call 'IsPossibleToDisableOnSite()' when displaying pop-up menu, disabling the menu item to disable if unable to disable.

Patch Set 1 #

Total comments: 6

Patch Set 2 : address comments #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3 lines) Patch
M src/plugin/PluginClass.cpp View 1 1 chunk +11 lines, -2 lines 4 comments Download
M src/plugin/PluginTabBase.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M src/plugin/PluginTabBase.cpp View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 9
Eric
The function 'CanDisableOnSite()' could have been inlined, it's true. I placed it in 'CPluginTab' in ...
3 years, 12 months ago (2015-12-08 19:05:34 UTC) #1
sergei
Actually, firstly we should discuss in the issue whether we want the menu item to ...
3 years, 12 months ago (2015-12-08 20:20:19 UTC) #2
Eric
> Actually, firstly we should discuss in the issue whether we want the > menu ...
3 years, 12 months ago (2015-12-09 12:48:35 UTC) #3
Oleksandr
On 2015/12/09 12:48:35, Eric wrote: > Regardless of what choice we make, there's a possible ...
3 years, 11 months ago (2015-12-17 12:59:38 UTC) #4
Eric
To be clear, I'd like to fix these defects first and deal with any subsequent ...
3 years, 11 months ago (2015-12-17 13:40:39 UTC) #5
Oleksandr
Fair enough. LGTM.
3 years, 11 months ago (2015-12-17 14:18:17 UTC) #6
sergei
On 2015/12/17 13:40:39, Eric wrote: > To be clear, I'd like to fix these defects ...
3 years, 11 months ago (2015-12-21 10:26:23 UTC) #7
Eric
On 2015/12/21 10:26:23, sergei wrote: > I disagree because removing of the item seems to ...
3 years, 11 months ago (2015-12-21 13:11:41 UTC) #8
sergei
3 years, 11 months ago (2016-01-08 10:07:02 UTC) #9
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5