chrome/content/actor.jsm - Issue 29332893: Issue 3431 - Element Hiding Helper shutdown fails (shutdown is not a function)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: chrome/content/actor.jsm

Issue 29332893: Issue 3431 - Element Hiding Helper shutdown fails (shutdown is not a function) (Closed)

Patch Set: Created Dec. 21, 2015, 12:16 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: chrome/content/actor.jsm

===================================================================

--- a/chrome/content/actor.jsm

+++ b/chrome/content/actor.jsm

@@ -22,17 +22,17 @@ let name = "elemhidehelper";

let actor = {

constructorFun: Actor,

constructorName: name,

name: name

};

DebuggerServer.addTabActor(actor, name);

-let shutdown = (function()

+var shutdown = (function()

saroyanm 2015/12/21 13:45:18 What is the reason of using "var" here ?

Wladimir Palant 2015/12/21 19:01:59 As I said, the problem here is https://bugzilla.mo

saroyanm 2015/12/23 10:55:34 Got it.

{

let executed = false;

return function()

{

if (!executed)

{

executed = true;

try

« no previous file with comments | « no previous file | chrome/content/frameScript.js » ('j') | chrome/content/frameScript.js » ('J')