Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29332950: Issue 3449 - Use sendRpcMessage instead of sendSyncMessage (Closed)

Created:
Dec. 22, 2015, 10:08 a.m. by Wladimir Palant
Modified:
Dec. 28, 2015, 1:18 p.m.
Reviewers:
saroyanm
Visibility:
Public.

Description

I cannot see too much of a change but at least the warning about ABP being slow doesn`t seem to be triggered any more.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lib/child/bootstrap.js View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 4
Wladimir Palant
Dec. 22, 2015, 10:08 a.m. (2015-12-22 10:08:51 UTC) #1
saroyanm
LGTM, with small nit. https://codereview.adblockplus.org/29332950/diff/29332951/lib/child/bootstrap.js File lib/child/bootstrap.js (right): https://codereview.adblockplus.org/29332950/diff/29332951/lib/child/bootstrap.js#newcode51 lib/child/bootstrap.js:51: function sendSyncMessageSingleResponse(messageName, data) nit: I ...
Dec. 28, 2015, 10:01 a.m. (2015-12-28 10:01:45 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29332950/diff/29332951/lib/child/bootstrap.js File lib/child/bootstrap.js (right): https://codereview.adblockplus.org/29332950/diff/29332951/lib/child/bootstrap.js#newcode51 lib/child/bootstrap.js:51: function sendSyncMessageSingleResponse(messageName, data) On 2015/12/28 10:01:44, saroyanm wrote: > ...
Dec. 28, 2015, 1:11 p.m. (2015-12-28 13:11:03 UTC) #3
saroyanm
Dec. 28, 2015, 1:13 p.m. (2015-12-28 13:13:06 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld