Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29333356: Noissue - Eliminate compile warnings in the plugin (Closed)

Created:
Jan. 11, 2016, 3:26 p.m. by Eric
Modified:
Jan. 12, 2016, 2:40 p.m.
Reviewers:
sergei, Oleksandr
CC:
Felix Dahlke
Visibility:
Public.

Description

Noissue - Eliminate compile warnings in the plugin Change the rectangle class to return unsigned values for its height and width functions. This entails adding guards to check the rectangle invariants. Add 'NotificationMessage::MoveToCenter()'. This removes code duplication in three places. In its implementation, explicitly cast coordinates for the notification message to 'short'. The rectangle coordinates they are derived from are 'long', but they're screen coordinates, so this operation preserves the integer value.

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M src/plugin/NotificationMessage.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/plugin/NotificationMessage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/plugin/PluginClass.cpp View 3 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 3
Eric
Jan. 11, 2016, 3:48 p.m. (2016-01-11 15:48:28 UTC) #1
sergei
LGTM
Jan. 11, 2016, 5:45 p.m. (2016-01-11 17:45:24 UTC) #2
Oleksandr
Jan. 12, 2016, 12:35 a.m. (2016-01-12 00:35:01 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld