Issue 29333441: Noissue - Change 'CPluginFilter::ShouldBlock()' to local function

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29333441: Noissue - Change 'CPluginFilter::ShouldBlock()' to local function (Closed)

Created:
Jan. 14, 2016, 2:29 p.m. by Eric

Modified:
Jan. 20, 2016, 2:56 p.m.

Reviewers:
sergei, Oleksandr

CC:
Felix Dahlke

Visibility:
Public.

Description

Noissue - Change 'CPluginFilter::ShouldBlock()' to local function 'CPluginFilter::ShouldBlock' was not using any member variables and was called in only a single place. Moved the function to its point of use. Removed 'CAdblockPlusClient::m_filter'. Its only use was to call 'ShouldBlock()'. Inlined the constructor, now with empty body.

Patch Set 1 #

Created: Jan. 14, 2016, 2:29 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -50 lines)			Patch
M	src/plugin/AdblockPlusClient.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	src/plugin/AdblockPlusClient.cpp	View	3 chunks	+37 lines, -6 lines	0 comments	Download
M	src/plugin/PluginFilter.h	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	src/plugin/PluginFilter.cpp	View	1 chunk	+0 lines, -32 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Eric

This is a simple refactoring change set. It would certainly be possible to more thoroughly ...

Jan. 14, 2016, 2:32 p.m. (2016-01-14 14:32:15 UTC) #1

LGTM

Expand All Messages | Collapse All Messages