Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29334565: Issue 1950 - Fixed: Filter tooltip not shown for long filters (Closed)

Created:
Jan. 26, 2016, 4:11 p.m. by Thomas Greiner
Modified:
Feb. 1, 2016, 12:52 p.m.
Reviewers:
Erik
CC:
Wladimir Palant
Visibility:
Public.

Description

Note that I'm displaying the last three lines instead of the last 240 characters. It doesn't appear to make a big difference but allowed me to simplify the code which is why I chose to differ from the ticket in that regard.

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M chrome/content/ui/filters-filteractions.js View 1 1 chunk +10 lines, -3 lines 0 comments Download
M chrome/content/ui/sidebar.js View 1 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 4
Thomas Greiner
Jan. 26, 2016, 4:17 p.m. (2016-01-26 16:17:26 UTC) #1
Erik
https://codereview.adblockplus.org/29334565/diff/29334566/chrome/content/ui/filters-filteractions.js File chrome/content/ui/filters-filteractions.js (right): https://codereview.adblockplus.org/29334565/diff/29334566/chrome/content/ui/filters-filteractions.js#newcode343 chrome/content/ui/filters-filteractions.js:343: if (lines.length > 6) I think this should be ...
Jan. 29, 2016, 4:29 a.m. (2016-01-29 04:29:31 UTC) #2
Thomas Greiner
https://codereview.adblockplus.org/29334565/diff/29334566/chrome/content/ui/filters-filteractions.js File chrome/content/ui/filters-filteractions.js (right): https://codereview.adblockplus.org/29334565/diff/29334566/chrome/content/ui/filters-filteractions.js#newcode343 chrome/content/ui/filters-filteractions.js:343: if (lines.length > 6) On 2016/01/29 04:29:31, Erik wrote: ...
Jan. 29, 2016, 6:28 p.m. (2016-01-29 18:28:56 UTC) #3
Erik
Jan. 29, 2016, 11:03 p.m. (2016-01-29 23:03:30 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld