src/JsValue.cpp - Issue 29334678: Issue 3589 - Change return type of AdblockPlus::JsValue::Call from pointer to r-value object.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/JsValue.cpp

Issue 29334678: Issue 3589 - Change return type of AdblockPlus::JsValue::Call from pointer to r-value object. (Closed)

Patch Set: Created Jan. 27, 2016, 11:17 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: src/JsValue.cpp

diff --git a/src/JsValue.cpp b/src/JsValue.cpp

index 1bc74903758f1911259d99c1dc48b16942fe6bcd..7519cf06e71a83b95fdd6055e86dd792f00d2b5b 100644

--- a/src/JsValue.cpp

+++ b/src/JsValue.cpp

@@ -205,7 +205,7 @@ std::string AdblockPlus::JsValue::GetClass() const

return Utils::FromV8String(obj->GetConstructorName());

}

-AdblockPlus::JsValuePtr AdblockPlus::JsValue::Call(const JsValueList& params, JsValuePtr thisPtr) const

+AdblockPlus::JsValue AdblockPlus::JsValue::Call(const JsValueList& params, JsValuePtr thisPtr) const

{

if (!IsFunction())

throw new std::runtime_error("Attempting to call a non-function");

@@ -233,5 +233,5 @@ AdblockPlus::JsValuePtr AdblockPlus::JsValue::Call(const JsValueList& params, Js

if (tryCatch.HasCaught())

throw JsError(tryCatch.Exception(), tryCatch.Message());

- return JsValuePtr(new JsValue(jsEngine, result));

+ return JsValue(jsEngine, result);

}