Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29338058: Issue 3695 - Edge exposes it's API with the "browser" namespace instead "chrome" (Closed)

Created:
March 10, 2016, 11:58 a.m. by Oleksandr
Modified:
March 14, 2016, 9:28 a.m.
Reviewers:
Sebastian Noack, kzar
Visibility:
Public.

Description

Issue 3695 - Edge exposes it's API with the "browser" namespace instead "chrome"

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ext/common.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Oleksandr
March 10, 2016, 12:04 p.m. (2016-03-10 12:04:58 UTC) #1
Sebastian Noack
LGTM. (But please don't push to upstream yet, I will setup a private BitBucket fork)
March 10, 2016, 12:32 p.m. (2016-03-10 12:32:25 UTC) #2
Sebastian Noack
March 10, 2016, 12:41 p.m. (2016-03-10 12:41:31 UTC) #3
There we go:
https://bitbucket.org/sebastian_noack/adblockplusedge/commits/ad1653dc90b195e...

I also gave you push access to that repo. So you can land further changes
yourself.

Powered by Google App Engine
This is Rietveld