Issue 29338107: Issue 3771 - Update adblockpluscore dependency and adapt filter validation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29338107: Issue 3771 - Update adblockpluscore dependency and adapt filter validation (Closed)

Created:
March 10, 2016, 2:54 p.m. by Sebastian Noack

Modified:
March 11, 2016, 5:28 p.m.

Reviewers:
kzar

CC:
Wladimir Palant

Visibility:
Public.

Description

Issue 3771 - Update adblockpluscore dependency and adapt filter validation

Patch Set 1 #

Patch Set 2 : Updated adblockplus dependecy and import new strings #

Created: March 11, 2016, 3:29 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -6 lines)			Patch
M	dependencies	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/filterValidation.js	View		2 chunks	+9 lines, -4 lines	0 comments	Download
M	metadata.common	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

kzar

Don't we also need to add the strings for these error messages? For example where ...

March 10, 2016, 4:17 p.m. (2016-03-10 16:17:31 UTC) #2

Sebastian Noack

On 2016/03/10 16:17:31, kzar wrote: > Don't we also need to add the strings for ...

March 10, 2016, 4:19 p.m. (2016-03-10 16:19:29 UTC) #3

Sebastian Noack

Since the strings landed now in adblockplus, I updated this review to import the related ...

March 11, 2016, 3:36 p.m. (2016-03-11 15:36:29 UTC) #4

kzar

LGTM (I don't want to argue about it, much less on your birthday, but I ...

March 11, 2016, 3:43 p.m. (2016-03-11 15:43:09 UTC) #5

Sebastian Noack

On 2016/03/11 15:43:09, kzar wrote: > (I don't want to argue about it, much less ...

March 11, 2016, 4:04 p.m. (2016-03-11 16:04:15 UTC) #6

kzar

March 11, 2016, 5:28 p.m. (2016-03-11 17:28:48 UTC) #7

Message was sent while issue was closed.

On 2016/03/11 16:04:15, Sebastian Noack wrote: 
> I will figure out what needs to be done to move the strings to adblockplusui.
> But for the time being I prefer to have the shared strings in one place.
> Besides, there might be more to be done in order to reuse those strings in
> Adblock Plus for Firefox.

OK, fair enough.

Expand All Messages | Collapse All Messages