Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(355)

Issue 29338156: Issue 3754 - Initial setup of the python-abp repo. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by Vasily Kuznetsov
Modified:
4 years ago
Reviewers:
Sebastian Noack
CC:
mathias, Felix Dahlke
Visibility:
Public.

Description

Issue 3754 - Initial setup of the python-abp repo.

Patch Set 1 #

Total comments: 18

Patch Set 2 : Address review comments (LICENSE.txt -> COPYING, .gitignore, encoding, license headers in empty fil… #

Total comments: 19

Patch Set 3 : Address review comments (ignore files, extra commands in setup.py, license text in readme, etc.) #

Patch Set 4 : Move style and coverage checking to tox.ini, strip setup.py to only have 'devenv' command, remove n… #

Total comments: 8

Patch Set 5 : Update ignore files, describe testing in README.md and fix a typo in tox.ini. #

Total comments: 7

Patch Set 6 : Remove pytest from qa dependencies in tox.ini, change "filterlist" to "filter list" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+825 lines, --2 lines) Patch
A .gitignore View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
A .hgignore View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
A COPYING View 1 1 chunk +674 lines, -0 lines 0 comments Download
M README.md View 1 2 3 4 5 1 chunk +26 lines, -0 lines 0 comments Download
A abp/__init__.py View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A abp/filters/__init__.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A setup.py View 1 2 3 4 5 1 chunk +68 lines, -0 lines 0 comments Download
A tests/test_line_parsing.py View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A tox.ini View 1 2 3 4 5 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 23
Vasily Kuznetsov
Initial commit into python-abp. No actual code there yet, but please look at the lincensing ...
4 years ago (2016-03-11 17:34:02 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29338156/diff/29338157/.gitignore File .gitignore (right): https://codereview.adblockplus.org/29338156/diff/29338157/.gitignore#newcode2 .gitignore:2: .cache I think we should only ignore those folders ...
4 years ago (2016-03-14 11:16:01 UTC) #2
Vasily Kuznetsov
Thanks for the comments. https://codereview.adblockplus.org/29338156/diff/29338157/.gitignore File .gitignore (right): https://codereview.adblockplus.org/29338156/diff/29338157/.gitignore#newcode2 .gitignore:2: .cache On 2016/03/14 11:16:00, Sebastian ...
4 years ago (2016-03-14 12:04:29 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29338156/diff/29338157/.gitignore File .gitignore (right): https://codereview.adblockplus.org/29338156/diff/29338157/.gitignore#newcode5 .gitignore:5: __ On 2016/03/14 12:04:28, Vasily Kuznetsov wrote: > On ...
4 years ago (2016-03-14 12:19:22 UTC) #4
Vasily Kuznetsov
https://codereview.adblockplus.org/29338156/diff/29338157/.gitignore File .gitignore (right): https://codereview.adblockplus.org/29338156/diff/29338157/.gitignore#newcode5 .gitignore:5: __ On 2016/03/14 12:19:22, Sebastian Noack wrote: > On ...
4 years ago (2016-03-14 17:20:42 UTC) #5
Vasily Kuznetsov
I uploaded an updated version: 1. LICENSE.txt is now called copying, 2. Encoding headers are ...
4 years ago (2016-03-15 11:10:46 UTC) #6
Sebastian Noack
https://codereview.adblockplus.org/29338156/diff/29338299/.gitignore File .gitignore (right): https://codereview.adblockplus.org/29338156/diff/29338299/.gitignore#newcode1 .gitignore:1: **/*.pyc Why not simply *.pyc? Moreover, in our other ...
4 years ago (2016-03-15 12:18:07 UTC) #7
Vasily Kuznetsov
https://codereview.adblockplus.org/29338156/diff/29338299/.gitignore File .gitignore (right): https://codereview.adblockplus.org/29338156/diff/29338299/.gitignore#newcode1 .gitignore:1: **/*.pyc On 2016/03/15 12:18:06, Sebastian Noack wrote: > Why ...
4 years ago (2016-03-15 13:14:36 UTC) #8
Sebastian Noack
https://codereview.adblockplus.org/29338156/diff/29338299/abp/__init__.py File abp/__init__.py (right): https://codereview.adblockplus.org/29338156/diff/29338299/abp/__init__.py#newcode16 abp/__init__.py:16: __import__('pkg_resources').declare_namespace(__name__) On 2016/03/15 13:14:35, Vasily Kuznetsov wrote: > On ...
4 years ago (2016-03-15 16:33:01 UTC) #9
Vasily Kuznetsov
In the absence of further comments I implemented the changes as I proposed. Let me ...
4 years ago (2016-03-15 16:36:18 UTC) #10
Vasily Kuznetsov
I moved most of the automation to tox.ini so only 'devenv' command is left in ...
4 years ago (2016-03-15 18:21:31 UTC) #11
Sebastian Noack
https://codereview.adblockplus.org/29338156/diff/29338379/.hgignore File .hgignore (right): https://codereview.adblockplus.org/29338156/diff/29338379/.hgignore#newcode1 .hgignore:1: ^.cache$ To be 100% consistent with the .gitignore you'd ...
4 years ago (2016-03-16 00:18:42 UTC) #12
Vasily Kuznetsov
TLDR: Agree with comments, new patch coming. https://codereview.adblockplus.org/29338156/diff/29338379/.hgignore File .hgignore (right): https://codereview.adblockplus.org/29338156/diff/29338379/.hgignore#newcode1 .hgignore:1: ^.cache$ On ...
4 years ago (2016-03-16 13:47:15 UTC) #13
Vasily Kuznetsov
4 years ago (2016-03-16 15:58:04 UTC) #14
Sebastian Noack
https://codereview.adblockplus.org/29338156/diff/29338452/setup.py File setup.py (right): https://codereview.adblockplus.org/29338156/diff/29338452/setup.py#newcode40 setup.py:40: subprocess.check_call([PIP, 'install'] + DEV_DEPENDENCIES) Wait, wouldn't that install these ...
4 years ago (2016-03-16 16:04:00 UTC) #15
Vasily Kuznetsov
https://codereview.adblockplus.org/29338156/diff/29338452/setup.py File setup.py (right): https://codereview.adblockplus.org/29338156/diff/29338452/setup.py#newcode40 setup.py:40: subprocess.check_call([PIP, 'install'] + DEV_DEPENDENCIES) On 2016/03/16 16:03:59, Sebastian Noack ...
4 years ago (2016-03-16 16:29:35 UTC) #16
Sebastian Noack
https://codereview.adblockplus.org/29338156/diff/29338452/setup.py File setup.py (right): https://codereview.adblockplus.org/29338156/diff/29338452/setup.py#newcode40 setup.py:40: subprocess.check_call([PIP, 'install'] + DEV_DEPENDENCIES) On 2016/03/16 16:29:35, Vasily Kuznetsov ...
4 years ago (2016-03-16 16:45:00 UTC) #17
Vasily Kuznetsov
https://codereview.adblockplus.org/29338156/diff/29338452/setup.py File setup.py (right): https://codereview.adblockplus.org/29338156/diff/29338452/setup.py#newcode40 setup.py:40: subprocess.check_call([PIP, 'install'] + DEV_DEPENDENCIES) On 2016/03/16 16:44:59, Sebastian Noack ...
4 years ago (2016-03-17 09:23:09 UTC) #18
Felix Dahlke
https://codereview.adblockplus.org/29338156/diff/29338452/README.md File README.md (right): https://codereview.adblockplus.org/29338156/diff/29338452/README.md#newcode3 README.md:3: A library for working with Adblock Plus filterlists. Nit: ...
4 years ago (2016-03-17 09:25:33 UTC) #19
Vasily Kuznetsov
On 2016/03/17 09:25:33, Felix Dahlke wrote: > https://codereview.adblockplus.org/29338156/diff/29338452/README.md > File README.md (right): > > https://codereview.adblockplus.org/29338156/diff/29338452/README.md#newcode3 ...
4 years ago (2016-03-17 10:00:59 UTC) #20
Sebastian Noack
LGTM
4 years ago (2016-03-17 11:23:33 UTC) #21
Vasily Kuznetsov
Changed "filterlist" to "filter list" in README and setup.py; also removed "pytest" from dependencies of ...
4 years ago (2016-03-17 14:43:59 UTC) #22
Sebastian Noack
4 years ago (2016-03-17 14:44:59 UTC) #23
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5