Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(81)

Issue 29338187: Issue 3696 - Fall back to tabs.create if windows.create isn't available (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by Oleksandr
Modified:
3 years, 11 months ago
Reviewers:
Sebastian Noack
CC:
kzar
Visibility:
Public.

Description

Issue 3696 - Fall back to tabs.create if windows.create isn't available

Patch Set 1 #

Total comments: 1

Patch Set 2 : Check only existence, not the type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M chrome/ext/background.js View 1 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 4
Oleksandr
3 years, 11 months ago (2016-03-14 07:57:57 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29338187/diff/29338188/chrome/ext/background.js File chrome/ext/background.js (right): https://codereview.adblockplus.org/29338187/diff/29338188/chrome/ext/background.js#newcode597 chrome/ext/background.js:597: if (typeof chrome.windows.create === "function"){ Nit; it should be ...
3 years, 11 months ago (2016-03-14 08:28:17 UTC) #2
Oleksandr
3 years, 11 months ago (2016-03-14 09:33:54 UTC) #3
Sebastian Noack
3 years, 11 months ago (2016-03-14 09:38:38 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5